Skip to content

Comments

Extract reusable "descendant registry" pattern from ActionBar, with new support for reordering elements#7585

Draft
iansan5653 wants to merge 4 commits intomainfrom
descendant-registry-pattern
Draft

Extract reusable "descendant registry" pattern from ActionBar, with new support for reordering elements#7585
iansan5653 wants to merge 4 commits intomainfrom
descendant-registry-pattern

Conversation

@iansan5653
Copy link
Contributor

@iansan5653 iansan5653 commented Feb 23, 2026

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8fd5b4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@iansan5653 iansan5653 changed the title Implement reusable "descendant registry" pattern from ActionBar, with new support for reordering elements Extract reusable "descendant registry" pattern from ActionBar, with new support for reordering elements Feb 23, 2026
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@iansan5653
Copy link
Contributor Author

iansan5653 commented Feb 23, 2026

@copilot Write unit tests for descendant-registry.tsx covering at least the following scenarios:

  • descendant items inside of other components
  • descendant items inside of React fragments
  • descendant items being added to the middle of the children after initial render
  • items being dropped after initial render
  • order of items changing after initial render, using key to maintain component mount
  • deep descendants added to beginning of tree after initial render

Copilot AI mentioned this pull request Feb 23, 2026
Merged
13 tasks
Copy link
Contributor

Copilot AI commented Feb 23, 2026

@iansan5653 I've opened a new pull request, #7586, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions github-actions bot temporarily deployed to storybook-preview-7585 February 23, 2026 22:21 Inactive
@iansan5653
Extract reusable "descendant registry" pattern from ActionBar, with…
d55720d 
… new support for reordering elements (#7586)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: iansan5653 <2294248+iansan5653@users.noreply.github.com>
@primer
Copy link
Contributor

primer bot commented Feb 24, 2026

🤖 Lint issues have been automatically fixed and committed to this PR.

@github-actions github-actions bot temporarily deployed to storybook-preview-7585 February 24, 2026 13:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iansan5653