WIP: Fix UnderlineNav CLS by using wrapping to overflow items onto the next (hidden) line#7505
WIP: Fix UnderlineNav CLS by using wrapping to overflow items onto the next (hidden) line#7505iansan5653 wants to merge 8 commits intomainfrom
UnderlineNav CLS by using wrapping to overflow items onto the next (hidden) line#7505Conversation
…e.module.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…e.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ate to detect overflow
|
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
This is just a quick proof of concept to show a CSS-based approach to hiding overflowing items. It uses
flex-wrapto wrap them onto the next line, along withoverflow: hiddenand an explicitheightto clip subsequent lines.In addition, this shows how we can use CSS
scroll-statecontainer queries to determine whether or not to show the tab icons and overflow menu initially.This is a minimal and quick PR - after the initial render, all the logic is still done by JS-based width calculations.
For more context, see https://github.com/github/primer/issues/6291#issuecomment-3861950186
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist