Merged
Conversation
yas-okadatech
commented
Jun 26, 2025
| spec.require_paths = ["lib"] | ||
|
|
||
| spec.add_runtime_dependency "savon", ">= 2.3.0", '< 3.0.0' | ||
| spec.add_runtime_dependency "nori", "2.6.0" |
Author
There was a problem hiding this comment.
新しいnoriが使われないように一時的にnoriを固定バージョンにしています
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the specs by updating XML namespace declarations and adjusts the corresponding test cases while also adding a new CI workflow to run RSpec tests.
- Updated namespace declarations in fixture helpers and adjusted client spec tests
- Added a new GitHub Actions workflow for running RSpec
- Added a new runtime dependency in the gemspec
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/support/fixture_helpers.rb | Changed namespace declarations to new identifiers |
| spec/lib/client_spec.rb | Adjusted test XML strings to use updated namespace identifiers |
| soapforce.gemspec | Added 'nori' as a runtime dependency |
| .github/workflows/rspec.yml | Introduced a CI workflow to run RSpec tests |
Comments suppressed due to low confidence (2)
spec/lib/client_spec.rb:322
- Verify that changing the namespace for the Id element from ins0 to ens is aligned with all related XML processing logic. This update should be reflected consistently in both the update and upsert test cases.
@body = "<tns:update><tns:sObjects><ins0:type>Opportunity</ins0:type><ens:Id>003ABCDE</ens:Id><tns:Name>SOAPForce Opportunity</tns:Name><tns:CloseDate>2013-08-12</tns:CloseDate><tns:StageName>Closed Won</tns:StageName></tns:sObjects></tns:update>"
spec/support/fixture_helpers.rb:35
- Ensure that the updated namespace identifiers (soap, fns, ens) are consistently utilized across all XML-based tests. Confirm that the mapping aligns with the expected XML structure in the application.
xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/"
kentoyoshida
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snakecase除去の前に、現在の状況でspecが通るようにしました。
また、spec実行用のCIを追加しました。
CIとSpecの修正は claudeが作成しました