Fix #8357: Calendar closes correctly on scroll#8427
Merged
melloware merged 1 commit intoprimefaces:masterfrom Dec 5, 2025
Merged
Fix #8357: Calendar closes correctly on scroll#8427melloware merged 1 commit intoprimefaces:masterfrom
melloware merged 1 commit intoprimefaces:masterfrom
Conversation
melloware
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the Calendar popup does not close when the page is scrolled (issue #8357). Previously, scrolling the page would leave the calendar popup open, sometimes causing it to move incorrectly and trigger JS errors.
Changes:
Added logic to close the calendar popup when the user scrolls the page.
Ensured that the scroll listener is properly attached and removed to avoid memory leaks.
Testing / Reproduction:
Run the showcase app (npm run dev).
Open the Calendar component.
Scroll the page — the calendar popup should now close immediately.
Screenshots / Before & After:
Before fix: View
After fix: View
Issue Reference:
Closes #8357