Dev/70/alex hierarchy #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
Author
|
To try it out go to In time we'll want to tweak it so that we don't repeat the inclusion of children in the JSON data. |
deploystream/lib/hierarchy.py
Outdated
Member
Author
|
@txels I've made those changes - although I haven't made the flat storage change as I wasn't sure if what you've done in your PR solved that issue for you? |
Member
|
The change in my PR actually does not "fix" the data structure mismatch, just adds more data with a different structure and the JS code ignores the rest. The proper fix will be to settle on a single structure that serves all use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works out the hierarchy of branches and exposes them correctly in the API.
get_feature_infoneeds to be written in the github provider.