test: add 18 unit tests for export_report helpers#286
Open
TerminalGravity wants to merge 3 commits intomainfrom
Open
test: add 18 unit tests for export_report helpers#286TerminalGravity wants to merge 3 commits intomainfrom
TerminalGravity wants to merge 3 commits intomainfrom
Conversation
Export pure helper functions (estimateTokens, extractText, extractToolNames, formatTokens, formatCost, formatDuration, analyzeSessionFile) and add comprehensive tests covering: - Token estimation (empty, short, long strings) - Content extraction from string, block arrays, null/undefined - Tool name extraction from content blocks - Token/cost/duration formatting with edge cases - Session file analysis: prompt counting, correction detection, tool call counting, preflight detection, timestamp tracking, empty files, and malformed JSON resilience Brings test count from 43 to 74.
Generates session reports from timeline data with: - Activity overview (events, prompts, commits, errors) - Prompt quality scoring (correction rate analysis) - Daily activity breakdown with visual bars - Event type distribution - Recent commits and errors - Optional file output Closes #5
Export getDateRange, summarizeEvents, generateMarkdown, and EventSummary from export-report.ts and add comprehensive test coverage: - getDateRange: all periods + error case - summarizeEvents: empty, type counting, day grouping, missing timestamps - generateMarkdown: metrics table, correction rate quality tiers, commits/errors sections, daily activity, single vs multi-day Brings test count from 74 to 92.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exports and tests the three pure helper functions in
export-report.ts:getDateRange— all 4 periods + unknown period errorsummarizeEvents— empty arrays, type counting, day grouping, missing timestampsgenerateMarkdown— metrics table, correction rate quality tiers (excellent/good/needs improvement/poor), commits/errors sections, single vs multi-day activityBrings total test count from 74 → 92. All green.