test: add 31 unit tests for estimate_cost helpers#285
Open
TerminalGravity wants to merge 1 commit intomainfrom
Open
test: add 31 unit tests for estimate_cost helpers#285TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
Export pure helper functions (estimateTokens, extractText, extractToolNames, formatTokens, formatCost, formatDuration, analyzeSessionFile) and add comprehensive tests covering: - Token estimation (empty, short, long strings) - Content extraction from string, block arrays, null/undefined - Tool name extraction from content blocks - Token/cost/duration formatting with edge cases - Session file analysis: prompt counting, correction detection, tool call counting, preflight detection, timestamp tracking, empty files, and malformed JSON resilience Brings test count from 43 to 74.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive unit tests for the
estimate_costtool's pure helper functions.Changes
estimate-cost.tsfor testabilitytests/tools/estimate-cost.test.tswith 31 tests covering:estimateTokens: empty, short, long stringsextractText: string, block arrays, null/undefined/number/objectextractToolNames: tool_use blocks, missing names, non-arraysformatTokens: raw numbers, k, M formatsformatCost: normal, sub-cent, zeroformatDuration: minutes, hours+minutes, zeroanalyzeSessionFile: prompt counting, corrections, tool calls, preflight detection, timestamps, empty files, malformed JSONTest results
Closes no issue — pure test coverage improvement.