fix: scorecard event type mismatch with session-parser#284
Open
TerminalGravity wants to merge 2 commits intomainfrom
Open
fix: scorecard event type mismatch with session-parser#284TerminalGravity wants to merge 2 commits intomainfrom
TerminalGravity wants to merge 2 commits intomainfrom
Conversation
Adds a ready-to-use CLAUDE.md template that makes Claude Code automatically run preflight_check on prompts. Users can copy it into their project to get preflight working without manual tool calls. Referenced from Quick Start in README and examples/README.
The session-parser emits events with type 'prompt' and 'assistant', but generate_scorecard filtered on 'user_prompt' and 'assistant_response'. This caused all user/assistant message arrays to be empty, making scorecard categories return default/misleading scores. Fix all event type filters to accept both naming conventions. Add regression test for event type matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
generate_scorecardfiltered events usinguser_promptandassistant_response, but the session-parser actually emitspromptandassistant. This meant every scorecard had empty user/assistant message arrays, causing most scoring categories to return default/misleading scores.Fix
Updated all event type filters in
generate-scorecard.tsto accept both naming conventions (prompt/user_prompt,assistant/assistant_response,git_commit/commit).Test
Added
tests/lib/scorecard-classify.test.ts— regression test for event type matching. All 47 tests pass.