test: add 11 unit tests for lib/state.ts#208
Open
TerminalGravity wants to merge 2 commits intomainfrom
Open
Conversation
- examples/.preflight/config.yml — profile, related projects, thresholds, embeddings - examples/.preflight/triage.yml — keyword rules and strictness tuning - examples/.preflight/contracts/api.yml — manual cross-service contract definitions - examples/README.md — quick setup instructions - README.md — link to examples from config reference section
Covers loadState, saveState, appendLog, readLog (including lastN, corrupt line handling, and 5MB rotation), and now(). Brings test count from 43 → 54.
This was referenced Mar 10, 2026
TerminalGravity
commented
Mar 11, 2026
Collaborator
Author
TerminalGravity
left a comment
TerminalGravity
left a comment
There was a problem hiding this comment.
Reviewed — solid state module coverage. The corrupt line handling and 5MB log rotation tests are especially good to have. Ready to merge.
TerminalGravity
commented
Mar 11, 2026
Collaborator
Author
TerminalGravity
left a comment
TerminalGravity
left a comment
There was a problem hiding this comment.
11 tests for state.ts — good coverage for a critical module. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers loadState, saveState, appendLog, readLog (including lastN, corrupt line handling, and 5MB log rotation), and now().
Also closed issue #172 and 4 stale duplicate PRs (#204-207) — fix was already on main.
Test count: 43 → 54.