fix: replace shell syntax in run() calls across 8 tools#202
Closed
TerminalGravity wants to merge 2 commits intomainfrom
Closed
fix: replace shell syntax in run() calls across 8 tools#202TerminalGravity wants to merge 2 commits intomainfrom
TerminalGravity wants to merge 2 commits intomainfrom
Conversation
run() uses execFileSync (no shell), so pipes, redirects, and non-git commands were silently broken. Fixed all 8 remaining tools: - verify-completion: use readFileSync for package.json, shell() for tsc/tests/build - token-audit: use readFileSync/statSync for line counting and file sizes, openSync/readSync for tail-reading large files - session-handoff: use shell() for command -v and gh pr list - audit-workspace: use array args for git commands, shell() for find|wc - sharpen-followup: use array args for git diff/status - scope-work: use array args, do grep/filter in JS - enrich-agent-task: use array args, readFileSync, JS filtering - sequence-tasks: use array args, slice in JS Added shell() helper to lib/git.ts for commands that genuinely need shell interpretation (non-git CLIs with pipes/redirects).
Fixes remaining broken run() calls in 4 tools: - clarify-intent: use shell() for pnpm/find commands with pipes - session-health: use array args + JS .pop() instead of pipe to tail - what-changed: use array args with JS fallback instead of || operator - checkpoint: use array args for add/commit/reset instead of string interpolation Part of #172
Collaborator
Author
|
Closing — superseded by #204 which covers all remaining tools. Let's consolidate there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken
run()calls that pass shell syntax (pipes, redirects,&&) toexecFileSyncwhich doesn't interpret them.Tools fixed in this PR:
clarify-intent:run()→shell()forpnpm tscandfindcommands with pipessession-health:run('git diff --stat | tail -1')→ array args + JS.pop()what-changed:run('git diff ... || git diff ...')→ array args with JS fallbackcheckpoint:run('git add ... && git commit ...')→ separate array-arg callsAll changes maintain existing behavior while actually working correctly with
execFileSync.Closes #172