fix: resolve shell syntax in git.run() across 8 tools#200
Closed
TerminalGravity wants to merge 1 commit intomainfrom
Closed
fix: resolve shell syntax in git.run() across 8 tools#200TerminalGravity wants to merge 1 commit intomainfrom
TerminalGravity wants to merge 1 commit intomainfrom
Conversation
…ools Adds shell() to lib/git.ts for commands that need pipes, redirects, or non-git executables. Fixes silent failures where 2>/dev/null, pipes, and shell operators were passed as literal git args via execFileSync. Tools fixed: verify-completion, token-audit, session-handoff, audit-workspace, sharpen-followup, scope-work, enrich-agent-task, sequence-tasks. Also replaced cat-via-git with fs.readFileSync in verify-completion. Closes #172
Collaborator
Author
|
Closing — superseded by #204 which covers all remaining tools. Let's consolidate there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172
Problem
git.run()usesexecFileSync('git', args)— no shell. But 8 tools passed shell operators that silently broke.Fix
shell()tolib/git.tsfor commands needing pipes/redirectsshell()cat package.jsonwithfs.readFileSyncTools fixed: verify-completion, token-audit, session-handoff, audit-workspace, sharpen-followup, scope-work, enrich-agent-task, sequence-tasks
Build passes, all 43 tests pass.