feat: use ambient_id crate for OIDC detection in CI
#35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, sorry I promised too much last week WRT this (I'm a little swamped right now): I have branch as well but I just haven't had time to test it yet so not sure if it's usable. I'll make the branch available as well in case you'd like to see -- I removed ambient.rs completely in my version: I think that makes sense. But obviously don't feel like you need to use that branch. |
Open
|
Thanks for the ping @wolfv, I'll do a review today! |
woodruffw
approved these changes
Jan 13, 2026
woodruffw
left a comment
woodruffw
left a comment
There was a problem hiding this comment.
Looks good to me!
(I see this drops support for some machine identity platforms that ambient-id doesn't support yet -- I'd be happy to collaborate on adding support for those upstream!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @woodruffw / @jku - would love a review on this PR :)