chore: remove old type-gen code #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjfaga
force-pushed
the
mfaga-remove-old-implementation
branch
from
d97fc7f to
01618d9
Compare
mjfaga
force-pushed
the
mfaga-remove-old-implementation
branch
from
01618d9 to
7634b53
Compare
jdwyah
approved these changes
Jun 17, 2025
Contributor
jdwyah
left a comment
jdwyah
left a comment
There was a problem hiding this comment.
terrific. much happier about the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After chatting with @jdwyah, we decided to scrap the old implementation altogether. I will be putting up a follow-on PR to re-implement python type generation.