Feat/plotly6 #338
Merged
Feat/plotly6 #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istent inline logic
jonasvdd
added
enhancement
…tlyAggregatorParser
…extensions and pyarrow versions in requirements.txt
Member
Author
|
Ready for review @jvdd! |
Parametrize test_utils.py on is_figure
… hanging in github actions)
jvdd
reviewed
Feb 21, 2025
Comment on lines
+29
to
+30
| - os: ubuntu-latest | ||
| python-version: '3.12' |
Member
Author
There was a problem hiding this comment.
Because the tests keep randomly hanging on python3.12 and ubuntu (without providing an error)
jvdd
reviewed
Feb 21, 2025
plotly_resampler/figure_resampler/figure_resampler_interface.py
Outdated
Show resolved
Hide resolved
jvdd
reviewed
Feb 21, 2025
plotly_resampler/figure_resampler/jupyter_dash_persistent_inline_output.py
Outdated
Show resolved
Hide resolved
jvdd
approved these changes
Feb 21, 2025
This was referenced Feb 21, 2025
Closed
jonasvdd
added a commit
that referenced
this pull request
Mar 6, 2025
* fix: check if update_data contains update before batch_update * add test + avoid same error when verbose=True * 🧹 create _hf_data_container if correct trace type * 🙏 python 3.7 not supported on Apple Silicon * remove WIP * 🖊️ more verbose asserts * 🖊️ more verbose asserts * 🙏 more sleep time * 🙏 * 🙌 * 🤔 fix for [BUG] Error handling timezones #305 * 🙈 linting * 💨 Refactor timezone handling in PlotlyAggregatorParser * Update minmax operator image Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> * Drop duplicate sentence * Feat/plotly6 (#338) * Parametrize test_utils.py on is_figure * 🔍 remove dtype parsing as orjon>3.10 supports float16 #118 * 💪 refactor: streamline JupyterDash integration and remove unused persistent inline logic * 💨 move construct_update_data_patch method into the FigureResampler class * 🐐 refactor: enhance test utilities and add support for Plotly>=6 data handling * 🙏 enhance serialization tests for plotly>6 * 📝 remove debug print statement and enhance type handling for hf_x * 🔒 update dependency versions in pyproject.toml to Support plotly 6 #334 * 🔍 drop python3.7 CI workflow and upgrade upload-artifact action * 🙏 fix pickling of figurewidget resampler * 🙏 fix tests * 💨 migration of code towards new upload artifact * 💪 enhance CI workflow to improve test result uploads and add retention settings * 🕳️ fix: ensure correct dtype handling for aggregated x indices in PlotlyAggregatorParser * ⬆️ chore: update dependency constraints for pandas and pyarrow in pyproject.toml * 🙈 fix linting * 🔍 fix: correct spelling in streamlit_app.py comments and update dash-extensions and pyarrow versions in requirements.txt * ⬆️ chore: update ipywidgets version constraint to allow for newer versions * 🚧 test: set random seed for reproducibility in test_wrap_aggregate * 🙈 chore: update ipywidgets version constraint for serialization support * 🙈 * 🔍 ci: conditionally skip tests on Python 3.12 for Ubuntu (as it keeps hanging in github actions) * 🔍 ci: exclude Python 3.12 on Ubuntu from test matrix to prevent hangs * 🖊️ review code * 🧹 cleanup comments --------- Co-authored-by: Maxim Ivanov <ivanovmg@gmail.com> Co-authored-by: jeroen <boebievdd@gmail.com> * 🤔 fix for [BUG] Error handling timezones #305 * 🙈 linting * 💨 Refactor timezone handling in PlotlyAggregatorParser * 📌 bug: Fix timezone handling for DST in PlotlyAggregatorParser and update tests --------- Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: jvdd <boebievdd@gmail.com> Co-authored-by: Jeroen Van Der Donckt <18898740+jvdd@users.noreply.github.com> Co-authored-by: Emmanuel Ferdman <emmanuelferdman@gmail.com> Co-authored-by: Maxim Ivanov <ivanovmg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues:
-> as we fixate orjson to
orjson^3.10, which supports f16, we can remove the casting method.-> Plotly 6 now utlizies
narwhalsto be more dataframe/array agnostic, resulting in non-exact behavior of tz-aware datatime casting / handling with the previous version.Moreover, whenever possible, data is serialized as a binary string, requiring helper methods to decode certain figure properties in our tests.
Features:
python3.13support!->We updated the package versions to support python 3.13
related PRs:
-> in this PR, we support
dash>=2.11which includes jupyterdash support (making thejupyter_dashdependency obsolete.Note: In order to support plotly6, we drop python 3.7!