Skip to content

Add perpendicular-flap solid-openfoam and solid-fenics cases to the system tests#746

Merged
MakisH merged 2 commits intoprecice:need-ref-results-updatefrom
AdityaGupta716:systemtests/add-perpendicular-flap-cases
May 9, 2026
Merged

Add perpendicular-flap solid-openfoam and solid-fenics cases to the system tests#746
MakisH merged 2 commits intoprecice:need-ref-results-updatefrom
AdityaGupta716:systemtests/add-perpendicular-flap-cases

Conversation

@AdityaGupta716
Copy link
Copy Markdown

@AdityaGupta716 AdityaGupta716 commented Mar 8, 2026

What this PR does

Adds two missing perpendicular-flap case combinations to the system tests:

  • {fluid-openfoam, solid-openfoam} → added to openfoam_adapter_pr and release_test
  • {fluid-openfoam, solid-fenics} → added to fenics_test and release_test

Refs #448

Checklist

  • I added a summary of any user-facing changes in changelog-entries/448.md
  • I will remember to squash-and-merge with a useful summary

@AdityaGupta716
Copy link
Copy Markdown
Author

Added {fluid-openfoam, solid-openfoam} and {fluid-openfoam, solid-fenics} to the system tests , covering two of the first-priority cases listed in #448 . Reference results need to be generated via CI. @MakisH happy to trigger that if you can point me to the right workflow.

@MakisH MakisH added GSoC Contributed in the context of the Google Summer of Code systemtests labels Mar 13, 2026
@AdityaGupta716 AdityaGupta716 marked this pull request as draft March 17, 2026 00:09
@AdityaGupta716 AdityaGupta716 force-pushed the systemtests/add-perpendicular-flap-cases branch from 42c59cc to 0942986 Compare April 4, 2026 06:49
@AdityaGupta716 AdityaGupta716 marked this pull request as ready for review April 4, 2026 07:00
@AdityaGupta716 AdityaGupta716 force-pushed the systemtests/add-perpendicular-flap-cases branch from 8e214c2 to 0942986 Compare April 4, 2026 07:01
@MakisH MakisH changed the title systemtests: add perpendicular-flap solid-openfoam and solid-fenics cases (refs #448) Add perpendicular-flap solid-openfoam and solid-fenics cases to the system tests May 9, 2026
@MakisH MakisH changed the base branch from develop to need-ref-results-update May 9, 2026 12:58
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding these cases, both are needed. I changed the base branch, as I am bundling multiple PRs that need new reference results into one branch, to update all in one run.

@MakisH MakisH merged commit 1065075 into precice:need-ref-results-update May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSoC Contributed in the context of the Google Summer of Code systemtests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants