Skip to content

Add pybind11 to dockerfile for system test#737

Open
Fujikawas wants to merge 15 commits intodevelopfrom
dockerdumux
Open

Add pybind11 to dockerfile for system test#737
Fujikawas wants to merge 15 commits intodevelopfrom
dockerdumux

Conversation

@Fujikawas
Copy link
Member

According to #696 (comment), the micro-manager participant in two-scale-heat-conduction case depends on pybind11.

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@Fujikawas Fujikawas self-assigned this Mar 2, 2026
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pybind11 is technically a dependency of micro-dumux, and not of the adapter. Could we install it right before the participant micro-dumux is compiled?

@Fujikawas
Copy link
Member Author

pybind11 is technically a dependency of micro-dumux, and not of the adapter. Could we install it right before the participant micro-dumux is compiled?

You are right. As pybind11 is also not an independent component that we would test etc. like the other adapters/MM, I'd tend to merge it into the installation of Micro Manager since it's often used between C++ case and MM. Also I would like to base the dumux-adapter on preCICE instead of MM.

@IshaanDesai
Copy link
Member

You are right. As pybind11 is also not an independent component that we would test etc. like the other adapters/MM, I'd tend to merge it into the installation of Micro Manager since it's often used between C++ case and MM. Also I would like to base the dumux-adapter on preCICE instead of MM.

Makes sense! Let's trigger the system test from this PR once the changes are done.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides #739 (comment), the rest of the changes make sense.

@IshaanDesai
Copy link
Member

Despite changing the DUMUX_ADAPTER_REF to a commit hash on its develop branch, the system test manual run still fails with an error that occurs because an older version of the adapter is used. This version was previously used in the system test. Could it be that the cache is not cleared?

@MakisH
Copy link
Member

MakisH commented Mar 19, 2026

Link to the job output?

@Fujikawas
Copy link
Member Author

@IshaanDesai
Copy link
Member

Link to the job output?

https://github.com/precice/tutorials/actions/runs/23255829787

The error that the participants two-scale-heat-conduction/macro-dumux, free-flow-dumux, and porous-media-dumux appear because the DuMuX adapter v3.0.0 gets picked. This happens despite b4d1d58, in which Jun changed the adapter reference to a commit on its develop branch. The question is why, despite doing this, the old version of the adapter got picked.

@MakisH
Copy link
Member

MakisH commented Mar 19, 2026

from the output:

WARNING: No argument provided for needed parameter DUMUX_VERSION. Substituting with 3.7
WARNING: No argument provided for needed parameter DUMUX_ADAPTER_REF. Substituting with main
WARNING: No argument provided for needed parameter DUNE_VERSION. Substituting with 2.9

are the changes already in main?

@IshaanDesai
Copy link
Member

Good catch! These changes are not in main. @Fujikawas, this means that the DUMUX_ADAPTER_REF is not set correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants