fix(defineMedia): replace tab with spaces in redirect_from YAML#6566
Open
mkdefinemedia wants to merge 5 commits into
Open
fix(defineMedia): replace tab with spaces in redirect_from YAML#6566mkdefinemedia wants to merge 5 commits into
mkdefinemedia wants to merge 5 commits into
Conversation
The YAML front matter in defineMedia.md used a hard tab character to indent the redirect_from list item. YAML does not allow tabs as indentation, causing Jekyll to throw a parse error and skip the file entirely. As a result, the Define Media adapter was not rendered on the download page. Replace the tab with two spaces to fix the YAML parse error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Is there anything else that needs to be done? Until this small fix is released, our adapter won't be listed. Can you give us a rough estimate of when that will happen? Thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The YAML front matter in
dev-docs/bidders/defineMedia.mdused a hard tab character to indent theredirect_fromlist item. YAML does not allow tabs as indentation tokens, so Jekyll throws a parse error and skips the file entirely:As a result, the Define Media adapter is not rendered on the Download page at https://docs.prebid.org/download.html.
Fix
Replace the tab with two spaces on line 7 of the front matter.
Testing
Local Jekyll build (
bundle exec jekyll build) with this fix applied no longer emits the YAML exception, and the adapter checkbox appears correctly in the generated_site/download.html.