Skip to content

Core: Fix incorrect enforcement of request.imp.metric #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osulzhenko wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −8
Open

Core: Fix incorrect enforcement of request.imp.metric #4460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/prebid/server/validation/ImpValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,8 +647,8 @@ private void validateMetrics(List<Metric> metrics, String msgPrefix) throws Vali
}

final Float value = metric.getValue();
if (value == null || value < 0.0 || value > 1.0) {
throw new ValidationException("%s.metric[%d].value must be in the range [0.0, 1.0]", msgPrefix, i);
if (value == null) {
throw new ValidationException("Missing %s.metric[%d].value", msgPrefix, i);
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions src/test/java/org/prebid/server/validation/ImpValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,15 +1298,15 @@ public void validateImpsShouldReturnValidationMessageWhenMetricTypeNullOrEmpty()
}

@Test
public void validateImpsShouldReturnValidationMessageWhenMetricValueIsNotValid() {
public void validateImpsShouldReturnValidationMessageWhenMetricValueNullOrEmpty() {
// given
final List<Imp> givenImps = singletonList(validImpBuilder()
.metric(singletonList(Metric.builder().type("viewability").value(2.0f).build())).build());
.metric(singletonList(Metric.builder().type("viewability").value(null).build())).build());

// when & then
assertThatThrownBy(() -> target.validateImps(givenImps, Collections.emptyMap(), null))
.isInstanceOf(ValidationException.class)
.hasMessage("request.imp[0].metric[0].value must be in the range [0.0, 1.0]");
.hasMessage("Missing request.imp[0].metric[0].value");
}

@Test
Expand Down Expand Up @@ -2370,15 +2370,15 @@ public void validateImpShouldReturnValidationMessageWhenMetricTypeNullOrEmpty()
}

@Test
public void validateImpShouldReturnValidationMessageWhenMetricValueIsNotValid() {
public void validateImpShouldReturnValidationMessageWhenMetricValueNullOrEmpty() {
// given
final Imp givenImp = validImpBuilder()
.metric(singletonList(Metric.builder().type("viewability").value(2.0f).build())).build();
.metric(singletonList(Metric.builder().type("viewability").value(null).build())).build();

// when & then
assertThatThrownBy(() -> target.validateImp(givenImp))
.isInstanceOf(ValidationException.class)
.hasMessage("imp[id=200].metric[0].value must be in the range [0.0, 1.0]");
.hasMessage("Missing imp[id=200].metric[0].value");
}

private static List<Imp> givenImps(UnaryOperator<Native.NativeBuilder> nativeCustomizer) {
Expand Down
Loading