-
Notifications
You must be signed in to change notification settings - Fork 224
Tests: Support GET interface profiles #4239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
osulzhenko
wants to merge
14
commits into
get-interface
Choose a base branch
from
functional-tests/general-get-interface
base: get-interface
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5a880fb
Tests: Support GET interface profiles
osulzhenko 1dd7157
Add functional tests for /get endpoint parameters
osulzhenko f6543e2
update after review
osulzhenko 10060d3
Merge branch 'refs/heads/master' into functional-tests/general-get-in…
osulzhenko 5126e00
update get interface tests
osulzhenko c981e37
Merge branch 'refs/heads/get-interface' into functional-tests/general…
osulzhenko a1a49d3
Merge branch 'refs/heads/get-interface' into functional-tests/general…
osulzhenko 934ea4a
Merge branch 'refs/heads/get-interface' into functional-tests/general…
osulzhenko bb42e74
update tests
osulzhenko 3b5c276
Merge branch 'refs/heads/get-interface' into functional-tests/general…
osulzhenko 25e4ff6
update tests
osulzhenko c88a5a2
update privacy tests
osulzhenko 6ba1166
Increase test coverage
osulzhenko 5056fdd
update after review
osulzhenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
src/test/groovy/org/prebid/server/functional/model/request/auction/Device.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| package org.prebid.server.functional.model.request.auction | ||
|
|
||
| import groovy.transform.EqualsAndHashCode | ||
| import groovy.transform.ToString | ||
| import org.prebid.server.functional.util.PBSUtils | ||
|
|
||
| @EqualsAndHashCode | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same don't need, since you comparing by fields |
||
| @ToString(includeNames = true, ignoreNulls = true) | ||
| class Device { | ||
|
|
||
|
|
||
5 changes: 5 additions & 0 deletions
5
src/test/groovy/org/prebid/server/functional/model/request/auction/DeviceExt.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
...st/groovy/org/prebid/server/functional/model/request/auction/StoredAuctionResponse.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...groovy/org/prebid/server/functional/model/request/get/CommaSeparatedListSerializer.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| package org.prebid.server.functional.model.request.get | ||
|
|
||
| import com.fasterxml.jackson.core.JsonGenerator | ||
| import com.fasterxml.jackson.databind.JsonSerializer | ||
| import com.fasterxml.jackson.databind.SerializerProvider | ||
|
|
||
| class CommaSeparatedListSerializer extends JsonSerializer<List<Object>> { | ||
|
|
||
| @Override | ||
| void serialize(List<Object> value, JsonGenerator generator, SerializerProvider serializers) throws IOException { | ||
| String result = value.join(',') | ||
| generator.writeString(result) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't need it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, check other cases, please remove when it's not really needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need all of them; it's part of the verification process