Skip to content

Conversation

@Net-burst
Copy link
Collaborator

@Net-burst Net-burst commented Nov 14, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#4028

🧠 Rationale behind the change

GZIP breaks Unruly bidder

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hosts
  • geographic host parameters are NOT required
  • NO direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@Net-burst Net-burst requested a review from osulzhenko November 14, 2024 18:40
@Net-burst Net-burst changed the title Remove GZIP compression as this breaks the bidder Unruly: Remove GZIP compression as this breaks the bidder Nov 14, 2024
@Compile-Ninja Compile-Ninja merged commit 4286f77 into master Nov 15, 2024
5 of 6 checks passed
@Compile-Ninja Compile-Ninja deleted the bidder/unruly-config-update branch November 15, 2024 14:23
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants