Skip to content

Expand on the phrase no commits needed for try-repo command#1020

Closed
jaredkoontz wants to merge 2 commits intopre-commit:mainfrom
jaredkoontz:patch-1
Closed

Expand on the phrase no commits needed for try-repo command#1020
jaredkoontz wants to merge 2 commits intopre-commit:mainfrom
jaredkoontz:patch-1

Conversation

@jaredkoontz
Copy link

I think this language should be improved.

When I read it, I assumed this meant that you could just git init a repo and start developing a plug-in. It seems however, that pre-commit expects there to be a commit on the repo after discussions here:
pre-commit/pre-commit#3441

@asottile
Copy link
Member

asottile commented Apr 1, 2025

the original language is fine: in order for something to be tracked it has to have been committed

@asottile asottile closed this Apr 1, 2025
@jaredkoontz
Copy link
Author

as an end user, i read what is currently written: a commit is not necessary to `try-repo` on a local directory.

that leads me to believe when running try-repo, a commit is not necessary. One can interpret the phrase a commit is not necessary to `try-repo` on a local directory. as create a git directory, throw in the .pre-commit-hooks.yml and start plugging away, which i did.

@asottile
Copy link
Member

asottile commented Apr 1, 2025

sure if you stop reading there yes it could be misleading. but that's why there's more words afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants