Fix named slices #244
Open
Fix named slices #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Can you add a test case for this? |
When a type is a slice of another type we should use the type name itself and not a slice of the elements of the slice. Fixes pquerna#243
erikdubbelboer
force-pushed
the
namedslice
branch
from
9c99bbd to
4d654a0
Compare
Contributor
Author
|
@pquerna I have added a test. Without my change the test will fail with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a type is a slice of another type we should use the type name itself and not a slice of the elements of the slice.
Fixes #243