Skip to content

sign: Consolidate make_hint and pack_sig_h_poly #1028

Open
mkannwischer wants to merge 1 commit intomainfrom
consolidate-make-pack-hint
Open

sign: Consolidate make_hint and pack_sig_h_poly #1028
mkannwischer wants to merge 1 commit intomainfrom
consolidate-make-pack-hint

Conversation

@mkannwischer
Copy link
Copy Markdown
Contributor

@mkannwischer mkannwischer commented Apr 8, 2026 •
edited
Loading

Replace mld_poly_make_hint + mld_pack_sig_h_poly with a single
mld_make_pack_sig_h_poly that takes (a0, a1) directly, computes hint
bits via mld_make_hint, writes hint indices into sig in one pass, and
returns the updated running tally. The function returns MLD_ERR_FAIL
if the number of hints would exceed MLDSA_OMEGA.

This removes the duplicated hint counting (previously make_hint
returned the count and pack iterated the hint poly again without
re-validating) and drops the temporary scratch hint polynomial from
the sign.c hint loop.

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 8, 2026 •
edited
Loading

CBMC Results (ML-DSA-87)

⚠️ Attention Required

Proof Status Current Previous Change
sign_verify_internal ⚠️ 251s 147s +71%
Full Results (183 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 2371s 2411s -1.7%
polyvecl_pointwise_acc_montgomery_c ✅ 301s 218s +38%
sign_verify_internal ⚠️ 251s 147s +71%
polyvec_matrix_expand ✅ 181s 255s -29%
poly_pointwise_montgomery_c ✅ 148s 186s -20%
rej_uniform_native ✅ 143s 155s -8%
mld_attempt_signature_generation ✅ 118s 96s +23%
mld_invntt_layer ✅ 92s 104s -12%
polyvec_matrix_expand_serial ✅ 73s 88s -17%
mld_ct_memcmp ✅ 72s 89s -19%
mld_ntt_layer ✅ 54s 59s -8%
sign_signature_internal ✅ 32s 41s -22%
polymat_permute_bitrev_to_custom ✅ 26s 27s -4%
poly_chknorm_c ✅ 21s 23s -9%
rej_uniform ✅ 21s 24s -12%
mld_compute_t0_t1_tr_from_sk_components ✅ 20s 25s -20%
mld_polyvecl_permute_bitrev_to_custom_native ✅ 20s 14s +43%
fqmul ✅ 18s 23s -22%
polyveck_ntt ✅ 17s 8s +112%
rej_uniform_c ✅ 15s 19s -21%
poly_uniform_4x ✅ 14s 17s -18%
poly_uniform_eta_4x ✅ 14s 16s -12%
polyt0_unpack ✅ 14s 20s -30%
keccakf1600x4_permute_native ✅ 13s 14s -7%
mld_check_pct ✅ 12s 17s -29%
mld_ntt_butterfly_block ✅ 12s 16s -25%
poly_add ✅ 12s 11s +9%
polyvec_matrix_pointwise_montgomery ✅ 12s 10s +20%
polyeta_unpack ✅ 11s 19s -42%
polyveck_add ✅ 11s 11s +0%
polyveck_power2round ✅ 11s 20s -45%
polyveck_sub ✅ 11s 7s +57%
keccak_absorb_once_x4 ✅ 10s 12s -17%
polyveck_reduce ✅ 10s 8s +25%
keccakf1600_permute_native ✅ 9s 9s +0%
mld_sample_s1_s2 ✅ 9s 5s +80%
polyveck_chknorm ✅ 9s 7s +29%
polyveck_decompose ✅ 9s 11s -18%
polyveck_pointwise_poly_montgomery ✅ 9s 6s +50%
polyveck_use_hint ✅ 9s 12s -25%
polyvecl_ntt ✅ 9s 9s +0%
polyz_unpack_c ✅ 9s 12s -25%
unpack_sk ✅ 9s 8s +12%
keccakf1600_permute ✅ 8s 6s +33%
polyveck_invntt_tomont ✅ 8s 10s -20%
polyveck_shiftl ✅ 8s 8s +0%
sign_pk_from_sk ✅ 8s 7s +14%
mld_compute_pack_z ✅ 7s 10s -30%
mld_sample_s1_s2_serial ✅ 7s 7s +0%
poly_decompose_c ✅ 7s 7s +0%
polyveck_caddq ✅ 7s 8s -12%
unpack_hints ✅ 7s 6s +17%
keccak_absorb ✅ 6s 7s -14%
keccak_squeezeblocks_x4 ✅ 6s 9s -33%
mld_h ✅ 6s 3s +100%
pack_pk ✅ 6s 4s +50%
pointwise_native_x86_64 ✅ 6s 2s +200%
poly_chknorm ✅ 6s 1s +500%
poly_invntt_tomont_c ✅ 6s 7s -14%
poly_uniform_eta ✅ 6s 7s -14%
rej_eta_native ✅ 6s 4s +50%
sign_open ✅ 6s 5s +20%
sign_signature_pre_hash_shake256 ✅ 6s 4s +50%
fqscale ✅ 5s 3s +67%
poly_caddq_c ✅ 5s 7s -29%
poly_invntt_tomont ✅ 5s 4s +25%
poly_power2round ✅ 5s 6s -17%
polyveck_unpack_eta ✅ 5s 6s -17%
polyvecl_chknorm ✅ 5s 8s -38%
rej_eta_c ✅ 5s 3s +67%
sign ✅ 5s 7s -29%
sign_keypair_internal ✅ 5s 6s -17%
decompose ✅ 4s 2s +100%
intt_native_x86_64 ✅ 4s 1s +300%
keccak_squeeze ✅ 4s 3s +33%
keccakf1600_xor_bytes ✅ 4s 2s +100%
make_pack_sig_h_poly ✅ 4s - new
mld_ct_cmask_neg_i32 ✅ 4s 2s +100%
mld_ct_cmask_nonzero_u32 ✅ 4s 3s +33%
mld_ct_get_optblocker_i64 ✅ 4s 4s +0%
mld_value_barrier_u8 ✅ 4s 3s +33%
ntt_native_aarch64 ✅ 4s 4s +0%
poly_caddq ✅ 4s 4s +0%
poly_challenge ✅ 4s 5s -20%
poly_invntt_tomont_native ✅ 4s 3s +33%
poly_ntt ✅ 4s 4s +0%
poly_shiftl ✅ 4s 5s -20%
poly_uniform ✅ 4s 5s -20%
poly_uniform_gamma1_4x ✅ 4s 2s +100%
poly_use_hint_native ✅ 4s 3s +33%
polyveck_unpack_t0 ✅ 4s 5s -20%
polyvecl_uniform_gamma1_serial ✅ 4s 2s +100%
polyvecl_unpack_eta ✅ 4s 5s -20%
polyz_pack ✅ 4s 2s +100%
polyz_unpack ✅ 4s 4s +0%
shake128_release ✅ 4s 3s +33%
shake256_init ✅ 4s 1s +300%
shake256x4_squeezeblocks ✅ 4s 2s +100%
sign_keypair ✅ 4s 3s +33%
sign_signature_pre_hash_internal ✅ 4s 4s +0%
sign_verify_extmu ✅ 4s 4s +0%
sign_verify_pre_hash_shake256 ✅ 4s 7s -43%
unpack_pk ✅ 4s 5s -20%
caddq ✅ 3s 2s +50%
keccak_f1600_x1_native_aarch64 ✅ 3s 1s +200%
keccak_f1600_x4_native_aarch64_v84a ✅ 3s 1s +200%
keccak_init ✅ 3s 3s +0%
keccakf1600_xor_bytes (big endian) ✅ 3s 3s +0%
keccakf1600x4_permute ✅ 3s 2s +50%
keccakf1600x4_xor_bytes ✅ 3s 3s +0%
mld_ct_cmask_nonzero_u8 ✅ 3s 2s +50%
mld_ct_get_optblocker_u8 ✅ 3s 2s +50%
mld_ct_sel_int32 ✅ 3s 2s +50%
mld_prepare_domain_separation_prefix ✅ 3s 4s -25%
pack_sig_c ✅ 3s 2s +50%
pack_sig_z ✅ 3s 4s -25%
poly_caddq_native ✅ 3s 2s +50%
poly_chknorm_native_aarch64 ✅ 3s 2s +50%
poly_decompose ✅ 3s 4s -25%
poly_ntt_native ✅ 3s 3s +0%
poly_pointwise_montgomery ✅ 3s 1s +200%
poly_use_hint ✅ 3s 3s +0%
polyt0_pack ✅ 3s 5s -40%
polyt1_pack ✅ 3s 3s +0%
polyveck_pack_eta ✅ 3s 4s -25%
polyveck_pack_t0 ✅ 3s 4s -25%
polyveck_pack_w1 ✅ 3s 4s -25%
polyvecl_pack_eta ✅ 3s 3s +0%
polyvecl_permute_bitrev_to_custom ✅ 3s 4s -25%
polyvecl_pointwise_acc_montgomery ✅ 3s 4s -25%
polyvecl_pointwise_acc_montgomery_native ✅ 3s 3s +0%
polyvecl_uniform_gamma1 ✅ 3s 2s +50%
polyw1_pack ✅ 3s 3s +0%
power2round ✅ 3s 2s +50%
reduce32 ✅ 3s 2s +50%
rej_eta ✅ 3s 3s +0%
shake128_finalize ✅ 3s 2s +50%
shake128x4_absorb_once ✅ 3s 2s +50%
shake256 ✅ 3s 3s +0%
shake256_release ✅ 3s 3s +0%
shake256_squeeze ✅ 3s 4s -25%
shake256x4_absorb_once ✅ 3s 2s +50%
sign_signature ✅ 3s 5s -40%
sign_signature_extmu ✅ 3s 6s -50%
sign_verify ✅ 3s 6s -50%
keccak_f1600_x1_native_aarch64_v84a ✅ 2s 2s +0%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 2s 1s +100%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 2s 1s +100%
keccak_finalize ✅ 2s 2s +0%
keccakf1600_extract_bytes (big endian) ✅ 2s 2s +0%
keccakf1600x4_extract_bytes ✅ 2s 2s +0%
make_hint ✅ 2s 4s -50%
mld_ct_get_optblocker_u32 ✅ 2s 3s -33%
mld_keccakf1600_extract_bytes ✅ 2s 2s +0%
mld_value_barrier_i64 ✅ 2s 2s +0%
mld_value_barrier_u32 ✅ 2s 1s +100%
ntt_native_x86_64 ✅ 2s 3s -33%
pack_sk ✅ 2s 6s -67%
pointwise_native_aarch64 ✅ 2s 4s -50%
poly_caddq_native_aarch64 ✅ 2s 5s -60%
poly_chknorm_native ✅ 2s 4s -50%
poly_decompose_native ✅ 2s 7s -71%
poly_ntt_c ✅ 2s 6s -67%
poly_pointwise_montgomery_native ✅ 2s 4s -50%
poly_reduce ✅ 2s 4s -50%
poly_sub ✅ 2s 3s -33%
poly_uniform_gamma1 ✅ 2s 2s +0%
poly_use_hint_c ✅ 2s 2s +0%
polyeta_pack ✅ 2s 5s -60%
polyvecl_unpack_z ✅ 2s 5s -60%
shake128_absorb ✅ 2s 3s -33%
shake128_init ✅ 2s 4s -50%
shake256_absorb ✅ 2s 4s -50%
shake256_finalize ✅ 2s 6s -67%
sign_verify_pre_hash_internal ✅ 2s 2s +0%
sys_check_capability ✅ 2s 3s -33%
unpack_sig ✅ 2s 3s -33%
use_hint ✅ 2s 2s +0%
mld_ct_abs_i32 ✅ 1s 3s -67%
montgomery_reduce ✅ 1s 3s -67%
polyt1_unpack ✅ 1s 3s -67%
polyz_unpack_native ✅ 1s 2s -50%
shake128_squeeze ✅ 1s 2s -50%
shake128x4_squeezeblocks ✅ 1s 2s -50%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 8, 2026 •
edited
Loading

CBMC Results (ML-DSA-44)

⚠️ Attention Required

Proof Status Current Previous Change
mld_attempt_signature_generation ⚠️ 179s 103s +74%
polyveck_decompose ⚠️ 21s 6s +250%
Full Results (183 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 2083s 2039s +2.2%
polyvecl_pointwise_acc_montgomery_c ✅ 332s 336s -1%
mld_attempt_signature_generation ⚠️ 179s 103s +74%
sign_verify_internal ✅ 175s 213s -18%
poly_pointwise_montgomery_c ✅ 148s 148s +0%
rej_uniform_native ✅ 140s 139s +1%
mld_invntt_layer ✅ 86s 85s +1%
mld_ct_memcmp ✅ 74s 72s +3%
mld_ntt_layer ✅ 55s 52s +6%
polyvec_matrix_expand ✅ 34s 23s +48%
rej_uniform ✅ 24s 20s +20%
poly_chknorm_c ✅ 21s 20s +5%
polyveck_decompose ⚠️ 21s 6s +250%
fqmul ✅ 19s 20s -5%
sign_signature_internal ✅ 19s 19s +0%
mld_compute_t0_t1_tr_from_sk_components ✅ 18s 11s +64%
poly_uniform_4x ✅ 17s 16s +6%
poly_uniform_eta_4x ✅ 16s 17s -6%
polyvec_matrix_expand_serial ✅ 16s 21s -24%
polyt0_unpack ✅ 15s 14s +7%
mld_ntt_butterfly_block ✅ 14s 11s +27%
polyeta_unpack ✅ 14s 16s -12%
polyz_unpack_c ✅ 13s 12s +8%
rej_uniform_c ✅ 13s 15s -13%
keccakf1600x4_permute_native ✅ 12s 13s -8%
poly_add ✅ 12s 10s +20%
keccak_absorb_once_x4 ✅ 11s 9s +22%
polymat_permute_bitrev_to_custom ✅ 11s 26s -58%
keccak_absorb ✅ 10s 5s +100%
keccakf1600_permute_native ✅ 10s 9s +11%
polyveck_power2round ✅ 10s 6s +67%
sign ✅ 10s 8s +25%
polyvecl_chknorm ✅ 9s 5s +80%
keccak_squeezeblocks_x4 ✅ 8s 6s +33%
keccakf1600_permute ✅ 8s 8s +0%
mld_check_pct ✅ 8s 12s -33%
mld_polyvecl_permute_bitrev_to_custom_native ✅ 8s 8s +0%
polyveck_pointwise_poly_montgomery ✅ 8s 3s +167%
polyveck_shiftl ✅ 8s 4s +100%
mld_compute_pack_z ✅ 7s 7s +0%
poly_decompose_c ✅ 7s 3s +133%
poly_invntt_tomont_c ✅ 7s 6s +17%
polyveck_chknorm ✅ 7s 3s +133%
unpack_sk ✅ 7s 7s +0%
poly_chknorm_native ✅ 6s 2s +200%
polyvec_matrix_pointwise_montgomery ✅ 6s 6s +0%
polyveck_invntt_tomont ✅ 6s 3s +100%
polyveck_sub ✅ 6s 4s +50%
polyveck_use_hint ✅ 6s 7s -14%
sign_keypair ✅ 6s 6s +0%
sign_pk_from_sk ✅ 6s 8s -25%
sign_signature ✅ 6s 5s +20%
mld_keccakf1600_extract_bytes ✅ 5s 3s +67%
mld_prepare_domain_separation_prefix ✅ 5s 6s -17%
mld_sample_s1_s2 ✅ 5s 6s -17%
ntt_native_aarch64 ✅ 5s 5s +0%
ntt_native_x86_64 ✅ 5s 4s +25%
poly_caddq_c ✅ 5s 5s +0%
poly_chknorm_native_aarch64 ✅ 5s 4s +25%
poly_power2round ✅ 5s 2s +150%
poly_uniform ✅ 5s 4s +25%
poly_uniform_eta ✅ 5s 5s +0%
poly_uniform_gamma1_4x ✅ 5s 4s +25%
polyt0_pack ✅ 5s 7s -29%
polyveck_add ✅ 5s 8s -38%
polyveck_pack_t0 ✅ 5s 3s +67%
polyvecl_ntt ✅ 5s 6s -17%
polyvecl_permute_bitrev_to_custom ✅ 5s 5s +0%
polyvecl_uniform_gamma1_serial ✅ 5s 3s +67%
sign_keypair_internal ✅ 5s 4s +25%
sign_verify_pre_hash_internal ✅ 5s 6s -17%
unpack_hints ✅ 5s 6s -17%
caddq ✅ 4s 2s +100%
intt_native_x86_64 ✅ 4s 3s +33%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 4s 1s +300%
keccakf1600x4_extract_bytes ✅ 4s 3s +33%
mld_h ✅ 4s 4s +0%
mld_sample_s1_s2_serial ✅ 4s 4s +0%
poly_decompose_native ✅ 4s 3s +33%
poly_invntt_tomont ✅ 4s 4s +0%
poly_sub ✅ 4s 3s +33%
polyt1_pack ✅ 4s 4s +0%
polyveck_caddq ✅ 4s 3s +33%
polyveck_ntt ✅ 4s 6s -33%
polyveck_pack_eta ✅ 4s 4s +0%
polyveck_reduce ✅ 4s 4s +0%
polyveck_unpack_eta ✅ 4s 4s +0%
polyvecl_uniform_gamma1 ✅ 4s 3s +33%
rej_eta_native ✅ 4s 6s -33%
sign_open ✅ 4s 3s +33%
sign_signature_extmu ✅ 4s 6s -33%
sign_signature_pre_hash_internal ✅ 4s 2s +100%
sign_verify_extmu ✅ 4s 4s +0%
unpack_pk ✅ 4s 2s +100%
decompose ✅ 3s 2s +50%
fqscale ✅ 3s 3s +0%
keccak_f1600_x1_native_aarch64_v84a ✅ 3s 3s +0%
keccak_f1600_x4_native_aarch64_v84a ✅ 3s 2s +50%
keccak_init ✅ 3s 2s +50%
keccak_squeeze ✅ 3s 6s -50%
keccakf1600_xor_bytes (big endian) ✅ 3s 2s +50%
keccakf1600x4_xor_bytes ✅ 3s 3s +0%
mld_ct_get_optblocker_u8 ✅ 3s 1s +200%
mld_ct_sel_int32 ✅ 3s 2s +50%
pack_pk ✅ 3s 4s -25%
pack_sig_z ✅ 3s 5s -40%
pointwise_native_x86_64 ✅ 3s 2s +50%
poly_caddq_native ✅ 3s 3s +0%
poly_chknorm ✅ 3s 2s +50%
poly_pointwise_montgomery ✅ 3s 3s +0%
poly_pointwise_montgomery_native ✅ 3s 3s +0%
poly_reduce ✅ 3s 3s +0%
poly_shiftl ✅ 3s 3s +0%
poly_use_hint_c ✅ 3s 4s -25%
poly_use_hint_native ✅ 3s 6s -50%
polyt1_unpack ✅ 3s 5s -40%
polyvecl_pack_eta ✅ 3s 4s -25%
polyvecl_unpack_z ✅ 3s 3s +0%
polyz_unpack_native ✅ 3s 3s +0%
power2round ✅ 3s 5s -40%
reduce32 ✅ 3s 2s +50%
rej_eta_c ✅ 3s 5s -40%
shake128_finalize ✅ 3s 3s +0%
shake128_squeeze ✅ 3s 3s +0%
shake128x4_squeezeblocks ✅ 3s 2s +50%
shake256 ✅ 3s 2s +50%
shake256_absorb ✅ 3s 2s +50%
shake256_finalize ✅ 3s 3s +0%
shake256_init ✅ 3s 2s +50%
shake256_release ✅ 3s 3s +0%
shake256_squeeze ✅ 3s 3s +0%
shake256x4_absorb_once ✅ 3s 4s -25%
sign_verify ✅ 3s 6s -50%
sign_verify_pre_hash_shake256 ✅ 3s 3s +0%
use_hint ✅ 3s 2s +50%
keccak_f1600_x1_native_aarch64 ✅ 2s 2s +0%
keccakf1600_extract_bytes (big endian) ✅ 2s 5s -60%
keccakf1600_xor_bytes ✅ 2s 2s +0%
make_pack_sig_h_poly ✅ 2s - new
mld_ct_cmask_neg_i32 ✅ 2s 1s +100%
mld_ct_cmask_nonzero_u32 ✅ 2s 2s +0%
mld_ct_cmask_nonzero_u8 ✅ 2s 3s -33%
mld_ct_get_optblocker_u32 ✅ 2s 2s +0%
mld_value_barrier_u32 ✅ 2s 1s +100%
montgomery_reduce ✅ 2s 2s +0%
pack_sig_c ✅ 2s 3s -33%
pack_sk ✅ 2s 3s -33%
pointwise_native_aarch64 ✅ 2s 2s +0%
poly_caddq ✅ 2s 3s -33%
poly_caddq_native_aarch64 ✅ 2s 4s -50%
poly_challenge ✅ 2s 7s -71%
poly_invntt_tomont_native ✅ 2s 2s +0%
poly_ntt ✅ 2s 2s +0%
poly_ntt_c ✅ 2s 2s +0%
poly_ntt_native ✅ 2s 1s +100%
poly_uniform_gamma1 ✅ 2s 3s -33%
poly_use_hint ✅ 2s 3s -33%
polyveck_pack_w1 ✅ 2s 3s -33%
polyveck_unpack_t0 ✅ 2s 3s -33%
polyvecl_pointwise_acc_montgomery ✅ 2s 3s -33%
polyvecl_pointwise_acc_montgomery_native ✅ 2s 4s -50%
polyw1_pack ✅ 2s 2s +0%
polyz_pack ✅ 2s 2s +0%
rej_eta ✅ 2s 4s -50%
shake128_init ✅ 2s 5s -60%
shake128x4_absorb_once ✅ 2s 4s -50%
sign_signature_pre_hash_shake256 ✅ 2s 4s -50%
sys_check_capability ✅ 2s 4s -50%
unpack_sig ✅ 2s 3s -33%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 1s 4s -75%
keccak_finalize ✅ 1s 4s -75%
keccakf1600x4_permute ✅ 1s 2s -50%
make_hint ✅ 1s 1s +0%
mld_ct_abs_i32 ✅ 1s 3s -67%
mld_ct_get_optblocker_i64 ✅ 1s 2s -50%
mld_value_barrier_i64 ✅ 1s 2s -50%
mld_value_barrier_u8 ✅ 1s 2s -50%
poly_decompose ✅ 1s 6s -83%
polyeta_pack ✅ 1s 2s -50%
polyvecl_unpack_eta ✅ 1s 3s -67%
polyz_unpack ✅ 1s 2s -50%
shake128_absorb ✅ 1s 3s -67%
shake128_release ✅ 1s 5s -80%
shake256x4_squeezeblocks ✅ 1s 1s +0%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Apr 8, 2026 •
edited
Loading

CBMC Results (ML-DSA-65)

⚠️ Attention Required

Proof Status Current Previous Change
mld_attempt_signature_generation ⚠️ 202s 107s +89%
polymat_permute_bitrev_to_custom ⚠️ 180s 37s +386%
Full Results (183 proofs)
Proof Status Current Previous Change
**TOTAL** ✅ 2573s 2329s +10.5%
polyvecl_pointwise_acc_montgomery_c ✅ 381s 280s +36%
mld_attempt_signature_generation ⚠️ 202s 107s +89%
polymat_permute_bitrev_to_custom ⚠️ 180s 37s +386%
sign_verify_internal ✅ 179s 286s -37%
poly_pointwise_montgomery_c ✅ 175s 156s +12%
rej_uniform_native ✅ 148s 148s +0%
polyvec_matrix_expand ✅ 102s 107s -5%
mld_invntt_layer ✅ 98s 94s +4%
mld_ct_memcmp ✅ 83s 79s +5%
polyvec_matrix_expand_serial ✅ 61s 81s -25%
mld_ntt_layer ✅ 57s 55s +4%
sign_signature_internal ✅ 27s 25s +8%
fqmul ✅ 22s 18s +22%
poly_chknorm_c ✅ 21s 19s +11%
polyvec_matrix_pointwise_montgomery ✅ 21s 15s +40%
rej_uniform ✅ 21s 22s -5%
mld_compute_t0_t1_tr_from_sk_components ✅ 18s 28s -36%
poly_uniform_4x ✅ 17s 15s +13%
poly_uniform_eta_4x ✅ 17s 16s +6%
mld_ntt_butterfly_block ✅ 16s 13s +23%
keccakf1600x4_permute_native ✅ 15s 13s +15%
polyt0_unpack ✅ 15s 15s +0%
rej_uniform_c ✅ 15s 15s +0%
poly_add ✅ 13s 10s +30%
mld_check_pct ✅ 12s 13s -8%
polyveck_power2round ✅ 12s 12s +0%
keccak_absorb_once_x4 ✅ 11s 10s +10%
polyveck_decompose ✅ 11s 16s -31%
polyveck_use_hint ✅ 11s 22s -50%
mld_polyvecl_permute_bitrev_to_custom_native ✅ 10s 8s +25%
polyveck_ntt ✅ 10s 7s +43%
polyveck_reduce ✅ 10s 5s +100%
unpack_sk ✅ 10s 9s +11%
polyeta_unpack ✅ 9s 6s +50%
polyz_unpack_c ✅ 9s 2s +350%
keccakf1600_permute ✅ 8s 10s -20%
keccakf1600_permute_native ✅ 8s 8s +0%
mld_compute_pack_z ✅ 8s 6s +33%
poly_decompose_c ✅ 8s 7s +14%
poly_invntt_tomont_c ✅ 8s 7s +14%
polyveck_caddq ✅ 8s 11s -27%
polyveck_shiftl ✅ 8s 7s +14%
polyveck_sub ✅ 8s 8s +0%
sign ✅ 8s 7s +14%
sign_keypair_internal ✅ 8s 6s +33%
sign_pk_from_sk ✅ 8s 9s -11%
unpack_hints ✅ 8s 5s +60%
keccak_absorb ✅ 7s 5s +40%
mld_h ✅ 7s 5s +40%
mld_sample_s1_s2 ✅ 7s 7s +0%
poly_use_hint_c ✅ 7s 4s +75%
polyveck_add ✅ 7s 10s -30%
polyveck_pointwise_poly_montgomery ✅ 7s 6s +17%
polyveck_unpack_t0 ✅ 7s 2s +250%
sign_signature_pre_hash_shake256 ✅ 7s 5s +40%
keccak_squeezeblocks_x4 ✅ 6s 6s +0%
poly_caddq_c ✅ 6s 5s +20%
poly_uniform_gamma1 ✅ 6s 5s +20%
polyveck_chknorm ✅ 6s 8s -25%
polyveck_invntt_tomont ✅ 6s 9s -33%
polyvecl_ntt ✅ 6s 5s +20%
polyvecl_pointwise_acc_montgomery_native ✅ 6s 3s +100%
fqscale ✅ 5s 4s +25%
keccak_f1600_x4_native_aarch64_v84a ✅ 5s 3s +67%
mld_sample_s1_s2_serial ✅ 5s 3s +67%
poly_caddq ✅ 5s 2s +150%
poly_caddq_native_aarch64 ✅ 5s 5s +0%
poly_challenge ✅ 5s 6s -17%
poly_uniform ✅ 5s 5s +0%
poly_uniform_gamma1_4x ✅ 5s 5s +0%
polyeta_pack ✅ 5s 4s +25%
polyveck_unpack_eta ✅ 5s 2s +150%
polyvecl_pack_eta ✅ 5s 3s +67%
rej_eta_c ✅ 5s 3s +67%
shake256x4_absorb_once ✅ 5s 1s +400%
sign_verify ✅ 5s 2s +150%
sign_verify_pre_hash_shake256 ✅ 5s 5s +0%
unpack_sig ✅ 5s 2s +150%
montgomery_reduce ✅ 4s 5s -20%
pack_pk ✅ 4s 3s +33%
pack_sig_c ✅ 4s 2s +100%
pointwise_native_x86_64 ✅ 4s 1s +300%
poly_decompose ✅ 4s 3s +33%
poly_decompose_native ✅ 4s 4s +0%
poly_invntt_tomont ✅ 4s 6s -33%
poly_ntt_native ✅ 4s 3s +33%
poly_power2round ✅ 4s 7s -43%
poly_reduce ✅ 4s 2s +100%
polyt0_pack ✅ 4s 3s +33%
polyt1_unpack ✅ 4s 5s -20%
polyvecl_chknorm ✅ 4s 5s -20%
polyvecl_unpack_eta ✅ 4s 3s +33%
polyvecl_unpack_z ✅ 4s 2s +100%
polyz_pack ✅ 4s 2s +100%
polyz_unpack_native ✅ 4s 5s -20%
rej_eta ✅ 4s 4s +0%
rej_eta_native ✅ 4s 5s -20%
shake128_release ✅ 4s 3s +33%
shake128_squeeze ✅ 4s 2s +100%
shake256 ✅ 4s 2s +100%
shake256_finalize ✅ 4s 2s +100%
sign_open ✅ 4s 4s +0%
sign_verify_pre_hash_internal ✅ 4s 6s -33%
caddq ✅ 3s 2s +50%
intt_native_x86_64 ✅ 3s 2s +50%
keccak_f1600_x1_native_aarch64 ✅ 3s 2s +50%
keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid ✅ 3s 1s +200%
keccakf1600x4_xor_bytes ✅ 3s 3s +0%
mld_ct_cmask_nonzero_u32 ✅ 3s 3s +0%
mld_ct_get_optblocker_u32 ✅ 3s 2s +50%
mld_ct_get_optblocker_u8 ✅ 3s 2s +50%
mld_prepare_domain_separation_prefix ✅ 3s 6s -50%
ntt_native_aarch64 ✅ 3s 3s +0%
ntt_native_x86_64 ✅ 3s 5s -40%
pack_sk ✅ 3s 4s -25%
poly_caddq_native ✅ 3s 2s +50%
poly_chknorm_native_aarch64 ✅ 3s 4s -25%
poly_ntt ✅ 3s 4s -25%
poly_ntt_c ✅ 3s 2s +50%
poly_pointwise_montgomery_native ✅ 3s 2s +50%
poly_sub ✅ 3s 3s +0%
poly_uniform_eta ✅ 3s 3s +0%
poly_use_hint ✅ 3s 1s +200%
polyveck_pack_t0 ✅ 3s 4s -25%
polyvecl_pointwise_acc_montgomery ✅ 3s 4s -25%
power2round ✅ 3s 2s +50%
shake128_absorb ✅ 3s 4s -25%
shake128_finalize ✅ 3s 1s +200%
shake128_init ✅ 3s 2s +50%
shake256_init ✅ 3s 2s +50%
sign_keypair ✅ 3s 2s +50%
sign_signature ✅ 3s 4s -25%
sign_signature_extmu ✅ 3s 4s -25%
sign_signature_pre_hash_internal ✅ 3s 7s -57%
sys_check_capability ✅ 3s 3s +0%
use_hint ✅ 3s 3s +0%
decompose ✅ 2s 4s -50%
keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid ✅ 2s 4s -50%
keccak_finalize ✅ 2s 1s +100%
keccak_init ✅ 2s 2s +0%
keccakf1600_xor_bytes ✅ 2s 2s +0%
make_hint ✅ 2s 2s +0%
make_pack_sig_h_poly ✅ 2s - new
mld_ct_cmask_neg_i32 ✅ 2s 4s -50%
mld_ct_cmask_nonzero_u8 ✅ 2s 2s +0%
mld_ct_get_optblocker_i64 ✅ 2s 2s +0%
mld_ct_sel_int32 ✅ 2s 4s -50%
mld_keccakf1600_extract_bytes ✅ 2s 1s +100%
mld_value_barrier_i64 ✅ 2s 4s -50%
mld_value_barrier_u32 ✅ 2s 1s +100%
mld_value_barrier_u8 ✅ 2s 4s -50%
pack_sig_z ✅ 2s 2s +0%
pointwise_native_aarch64 ✅ 2s 3s -33%
poly_chknorm ✅ 2s 2s +0%
poly_chknorm_native ✅ 2s 3s -33%
poly_invntt_tomont_native ✅ 2s 3s -33%
poly_pointwise_montgomery ✅ 2s 6s -67%
poly_shiftl ✅ 2s 2s +0%
polyt1_pack ✅ 2s 3s -33%
polyveck_pack_eta ✅ 2s 3s -33%
polyvecl_permute_bitrev_to_custom ✅ 2s 4s -50%
polyvecl_uniform_gamma1_serial ✅ 2s 2s +0%
polyw1_pack ✅ 2s 3s -33%
polyz_unpack ✅ 2s 4s -50%
reduce32 ✅ 2s 3s -33%
shake128x4_absorb_once ✅ 2s 3s -33%
shake128x4_squeezeblocks ✅ 2s 3s -33%
shake256_release ✅ 2s 3s -33%
shake256_squeeze ✅ 2s 5s -60%
sign_verify_extmu ✅ 2s 2s +0%
keccak_f1600_x1_native_aarch64_v84a ✅ 1s 3s -67%
keccak_squeeze ✅ 1s 6s -83%
keccakf1600_extract_bytes (big endian) ✅ 1s 4s -75%
keccakf1600_xor_bytes (big endian) ✅ 1s 3s -67%
keccakf1600x4_extract_bytes ✅ 1s 1s +0%
keccakf1600x4_permute ✅ 1s 5s -80%
mld_ct_abs_i32 ✅ 1s 2s -50%
poly_use_hint_native ✅ 1s 4s -75%
polyveck_pack_w1 ✅ 1s 3s -67%
polyvecl_uniform_gamma1 ✅ 1s 3s -67%
shake256_absorb ✅ 1s 3s -67%
shake256x4_squeezeblocks ✅ 1s 3s -67%
unpack_pk ✅ 1s 4s -75%

@mkannwischer mkannwischer force-pushed the consolidate-make-pack-hint branch from 4ca59ed to edf6619 Compare April 8, 2026 06:58
@mkannwischer mkannwischer marked this pull request as ready for review April 8, 2026 08:37
@mkannwischer mkannwischer requested a review from a team as a code owner April 8, 2026 08:37
hanno-becker
hanno-becker reviewed Apr 9, 2026
View reviewed changes
hanno-becker
hanno-becker requested changes Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks good, but I'd prefer a clean error signal when there are too many hints, see comment.

@mkannwischer mkannwischer force-pushed the consolidate-make-pack-hint branch from edf6619 to 7b6a8a4 Compare April 9, 2026 09:22
@mkannwischer
sign: Consolidate make_hint and pack_sig_h_poly
e8dabd1 
Replace mld_poly_make_hint + mld_pack_sig_h_poly with a single
mld_make_pack_sig_h_poly that takes (a0, a1) directly, computes hint
bits via mld_make_hint, writes hint indices into sig in one pass, and
returns the updated running tally. The function returns MLD_ERR_FAIL
if the number of hints would exceed MLDSA_OMEGA.

This removes the duplicated hint counting (previously make_hint
returned the count and pack iterated the hint poly again without
re-validating) and drops the temporary scratch hint polynomial from
the sign.c hint loop.

Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
@mkannwischer mkannwischer force-pushed the consolidate-make-pack-hint branch from 7b6a8a4 to e8dabd1 Compare April 9, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanno-becker hanno-becker Awaiting requested review from hanno-becker

Requested changes must be addressed to merge this pull request.

Assignees

@hanno-becker hanno-becker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Signing: Combine mld_poly_make_hint and mld_pack_sig_h_poly

3 participants

@mkannwischer @oqs-bot @hanno-becker