lowram: Stream matrix A element-by-element to reduce memory#1019
Open
mkannwischer wants to merge 1 commit intomainfrom
Open
lowram: Stream matrix A element-by-element to reduce memory#1019mkannwischer wants to merge 1 commit intomainfrom
mkannwischer wants to merge 1 commit intomainfrom
Conversation
7013003 to
5ccd3c2
Compare
Contributor
CBMC Results (ML-DSA-65)
Full Results (184 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (184 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (184 proofs)
|
3acbf60 to
9ba57ff
Compare
Replace the row-level matrix buffer (mld_polyvecl) with a single-poly buffer in REDUCE_RAM mode. In the lazy path, matrix elements A[k][l] are sampled on demand one at a time, and the matrix-vector product accumulates element-by-element instead of row-by-row. Restructure polymat into eager/lazy variants following the same pattern as s1hat/s2hat/t0hat: - mld_polymat_eager: stores full K x L matrix - mld_polymat_lazy: stores rho + single poly_buffer + tmp - mld_polyvec_matrix_expand_eager/_lazy: separate implementations - mld_polyvec_matrix_pointwise_montgomery_eager/_lazy: separate implementations with CBMC contracts only on the eager variants Move all polymat-related code from polyvec.h/polyvec.c into polyvec_lazy.h/polyvec_lazy.c. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
9ba57ff to
bb6bd8b
Compare
This was referenced Apr 8, 2026
mkannwischer
commented
Apr 9, 2026
Comment on lines
+213
to
+216
| typedef struct | ||
| { | ||
| mld_polyvecl vec[MLDSA_K]; | ||
| } mld_polymat_eager; |
Contributor
Author
There was a problem hiding this comment.
This needs to be guarded, otherwise this will fail on AVR.
Contributor
Author
There was a problem hiding this comment.
The compiler failed for me saying that you can't declare a struct larger than 32 KiB even if the struct is not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the row-level matrix buffer (mld_polyvecl) with a single-poly
buffer in REDUCE_RAM mode. In the lazy path, matrix elements A[k][l]
are sampled on demand one at a time, and the matrix-vector product
accumulates element-by-element instead of row-by-row.
Restructure polymat into eager/lazy variants following the same pattern
as s1hat/s2hat/t0hat:
implementations with CBMC contracts only on the eager variants
Move all polymat-related code from polyvec.h/polyvec.c into
polyvec_lazy.h/polyvec_lazy.c.