Skip to content

Conversation

@jonenst
Copy link
Contributor

@jonenst jonenst commented Nov 13, 2019

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
No autocomplete

What is the new behavior (if this is a feature change)?
Autocomplete

Other information:
This is a POC autocomplete. If we decided to keep it, we should continue the work:

  • extract the json in a separate url (it is currently embedded in search.html)
  • setup the autocomplete in all the pages
  • cleanup a bit

demo:

autocomplete

After this patch, the following files are no longer indexed:
"/", because layout == home
"/index.md.bck", not interpreted as markdown so no title
"/docs/loadflow/loadflow.html", layout == todo
"/assets/css/custom.css", no title
"/assets/css/main.css", no title
"/assets/css/style.css", no title

Signed-off-by: Jon Harper <jon.harper87@gmail.com>
Stripping new lines would fuse words across two consecutive lines, putting garbage in the index
lunr handles newlines just fine

Signed-off-by: Jon Harper <jon.harper87@gmail.com>
Signed-off-by: Jon Harper <jon.harper87@gmail.com>
Signed-off-by: Jon Harper <jon.harper87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants