Refactor building schema statements #161
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors how
CREATE VIEW,CREATE TRIGGERandCREATE INDEXstatements are constructed inpowersync_replace_schema.The main motivation here is that we want to be able to generate triggers for raw tables as well. At the moment,
CREATE TRIGGERstatements are built from a string template specialized for the type of trigger and table. To be able to re-use some of that logic for raw tables in the future, this adds theSqlBufferutility. It contains several methods to write identifiers, string literals and common fragments into aStringbuffer. In particular, writing intopowersync_crudand defining the "header" ofCREATE TRIGGERstatements has been refactored into common method calls instead of being a large string literal.This PR doesn't change the statements generated by the core extension (apart from whitespace). It drastically reduces the amount of intermediate
Stringallocations, but I don't expect that to have a meaningful impact on performance.This also updates Rust to 1.93, to be able to use the standardized
fmt::from_fn, allowing us to provide a callback responsible describing how to format a fragment.