test(unit): Fix deadlock caused by sys.argv changes under forkserver
#721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfieni
force-pushed
the
test/fix-deadlock-forkserver
branch
from
49b47b2 to
b02d1dc
Compare
gfieni
force-pushed
the
test/fix-deadlock-forkserver
branch
from
b02d1dc to
92ddd49
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a deadlock that occurred when running the test suite on Python 3.14 under Unix.
The issue was caused by the new default multiprocessing start method,
forkserver, introduced in Python 3.14, combined with theclimodule’s tests modifyingsys.argvdirectly. This interaction caused failures when the test runner spawned new processes.Any modules using actors were affected when the
tests/unit/clitests ran first.