You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a temptative PR that implements settings and device arguments to control Bias T during TX and RX. They are called bias_tx and bias_rx respectively. The rationale behind this is that a setting named bias_tx already existed, and it made sense to keep separate settings (and device arguments) to configure this option.
Looks good in general. I know hackrf can be a little sensitive to settings being changed and switching between tx and rx modes.
Take a look at these sections in HackRF_Streaming.cpp and how they conditionally apply settings, you may need to so something similar to keep the switching happy.
// determine what (if any) settings need to be changed for RX; only applicable if there is both a source and sink block // determine what (if any) settings need to be changed for TX; only applicable if there is both a source and sink block
Good catch, I had no idea. I was setting the antenna voltage unconditionally prior to starting streaming. I've just added some changes to keep certain _current_bias flag that is checked before starting streaming. Note this still needs to be done even if we do not switch between TX / RX: these setting may be defined as a device argument (which is the case for SigDigger) and activateStream could be the first opportunity we have to apply the bias config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a temptative PR that implements settings and device arguments to control Bias T during TX and RX. They are called
bias_txandbias_rxrespectively. The rationale behind this is that a setting namedbias_txalready existed, and it made sense to keep separate settings (and device arguments) to configure this option.Looking forward for your feedback,