-
Notifications
You must be signed in to change notification settings - Fork 74
add helm postal chart #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Looks good, might be worth adding a HorizontalPodAutoscaler for the web/smtp or maybe a config option for the number of replicas of them? |
I added replicas to values |
|
Can the worker use more than one replica? |
|
JFYI, stuff like: Don't have to be dependency. Both init and make user can be wrapped inside check if we have initialized before and have default admin user on not. This is question of entry point honestly. There is many ways to handle it, f.e.: read env vars that will contains init user secret that will be set in helm values or via providing existing secret name and key name. |
|
Please add to each deployment stuff like: P.s:
|
|
|
@dragoangel thank you for improving this. Any other improvements for helm chart are also welcomed. |
|
Hi @dmitryzykov, unfortunately, not have many time for that, I'm not using postal atm, but you can collect my feedback and improve your PR, I copied samples that I had from other places and adjusted a bit, you can "polish" them a bit and it will be cool. |
|
@dragoangel can you just attach your helm chart folder as zip archive? Will add it to pr |
|
No, you got me wrong, I not have postal at all :) I just reviewing your PR |
|
@dragoangel got it now :) Anyway if someone will find this helpful and tested this - any changes in PR format are welcomed. |
|
also we need have: And for smtp, can be same but instead of For worker - I don't know, we can exec command in container and check if proccess running, or sort of that. |
|
@dmitryzykov how is the postal runner handled? I see smtp, web, and worker not the runner. it's not needed? it was removed. solved. Still wonder why this is not merged? By now could had been improved by community members @adamcooke can you consider approving this PR and merge it? |
|
Hello all! What is the status here? |
@willpower232 any ideas on how we can handle this? I am really willing to give some time to improve this helm chart. First would be nice to approve it, and allow us to improve it. |
|
It looks like there is a /health endpoint on port 9090 of the web container and 9091 of the smtp container I would love to be able to merge but I don't have that permission. |
|
@adamcooke any plans to merge? |
|
I made also a postal chart but adapted for kubee I took a look to the PR but there was too much to do (I don’t remember the details but the diff in values file should be explicit) Technically, postal uses the same binary (ie same manifest) but with different command. The env is in a yaml file and is the same for all 3 service. I tried to replicate it. The whole postal configuration is in the values file except the secret. For installation or upgrade, postal does not have idempotent cli command so there is only the installation. Before accepting any PR, I vote for the fact that the whole configuration should be in the values file. My 2 cents. |
This PR add kubernetes helm chart for postal.
init db and create admin user:
tested with:
It exposes web using ingress
and using port 25 on load balancer type for smtp
mysql installation is not part of chart, so DB should be installed before this chart
Will not be able to spend much time on polishing this chart, but still think might be helpful for community.