feat: Specific starting apps for the editor only view#153
Open
feat: Specific starting apps for the editor only view#153
Conversation
georgestagg
approved these changes
Jul 19, 2024
Collaborator
georgestagg
left a comment
georgestagg
left a comment
There was a problem hiding this comment.
This looks reasonable to me.
If we wanted to avoid the extra complexity we could also just add your minimal example as the first app, named something like 000-basic. However, this way works OK too.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app template we use for https://shinylive.io/r/editor currently opens an app with a decent bit of code and comments (compare it with https://shinylive.io/py/editor).
As a heavy user of shinylive.io/r/editor, this adds a decent bit of friction because I need to delete most of the app before I can start working on my example.
This PR modifies the current example flow to add support for a special "Editor" category that, when present, is the starting code for the
{appEngine}/editor/end point. In{appEngine}/examples/page, the Editor category is filtered out and won't appear in the sidebar.