Conversation
ECR is no longer used - images are now pulled from public registries. - Remove ECR repository creation from workload and control room persistent steps - Remove ECR VPC endpoints (ecr.api, ecr.dkr) from standard VPC endpoint services - Delete lib/aws/ecr.go and stub Registry methods with ErrECRDeprecated - Remove manage_ecr_repositories config option - Remove ecr-login, skopeo-login, latest-images Justfile recipes
7 tasks
timtalbot
approved these changes
Feb 3, 2026
Contributor
timtalbot
left a comment
timtalbot
left a comment
There was a problem hiding this comment.
Nice! Can we just outright delete registry.go and registry_test.go too?
Contributor
Author
I'm going to leave them to document the deprecation in case existing users of the CLI try to leverage those features. I can remove it one or two releases from now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
ECR is no longer used - images are now pulled from public registries. This removes all ECR-related code and VPC endpoints.
Test plan