e2e: posit-assistant flake - drop afterAll logout hook#13847
Merged
Conversation
The app fixture is worker-scoped and the worker tears down after the spec file, so the logout cleanup adds no isolation but does add CI flake surface. Drop it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
E2E Tests 🚀 |
midleman
changed the title
jonvanausdeln
approved these changes
May 28, 2026
Contributor
jonvanausdeln
left a comment
jonvanausdeln
left a comment
There was a problem hiding this comment.
LGTM!
It's cool for now.. not sure how I feel about a separate spec for each provider, but cross that bridge when we get there, etc.
Contributor
Author
Good deal, we'll worry about that day when it comes. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
afterAlllogout hook fromposit-assistant.test.tsto address this flake.appfixture is worker-scoped and the worker tears down after the spec file finishes, so the logout adds no isolationPOSIT_ASSISTANT_PROVIDERStoday; if we add more, prefer a separate spec per provider over re-adding the hook.QA Notes
@:posit-assistant @:assistant