e2e: nb side-by-side flake#13843
Merged
Merged
Conversation
|
E2E Tests 🚀 |
midleman
changed the title
Member
|
@midleman, since side-by-side notebooks are an (important) edge case, I believe we should fell comfortable soft-failing or skipping it temporarily in the future in case this creates too much noise again. I say that because, when I see your note about the temporary workaround, it makes me think that future kernel modifications/improvements (esp. focused on a more polished experience) may end up having this test fail. cc @dhruvisompura LGTM though! ✅ |
rodrigosf672
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flake in
notebook-side-by-side.test.ts. Root cause turned out to be inter-test state: the prior test callskernel.shutdown()andkernel.restart()on its notebooks, leaving session state that breaks the next test's notebook autostart/selection.kernel.select('Python')and rely on autostartQA Notes
@:positron-notebooks @:web @:win