Fix notebook kernel badge spinning forever#13834
Merged
Merged
Conversation
The badge icon now reflects session state. No attached session means Disconnected. Switching and Discovering remain explicit Active overrides for user/app transitions.
|
E2E Tests 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13688
The notebook kernel badge spun forever when a saved notebook was opened.
This PR simplifies the badge's icon logic so it reflects session state directly: no attached session means Disconnected, a live session drives the icon via its
RuntimeState, andSwitching/Discoveringnow only showActive. Previously we would fallback to showingActiveif we had a kernel but no session yet which is what caused the infinite spinner to show up until we interacted with the notebook.This is closer to what we do for Quarto kernels.
Screenshots
BEFORE
Screen.Recording.2026-05-27.at.3.48.36.PM.mov
AFTER
Screen.Recording.2026-05-27.at.3.48.19.PM.mov
Release Notes
New Features
Bug Fixes
Validation Steps
@:positron-notebooks
@:sessions
.ipynbwith a remembered kernel. The badge should showDisconnectedinstead of theActivespinner.Activewith the new kernel name (kernel is inSwitchingstate), then the new session attaches and the badge showsIdle.Activeduring Restart and then showsIdle.Disconnected+ kernel name (kernel is inExitedstate).