Add theme colors for base checkboxes#13813
Merged
Merged
Conversation
|
E2E Tests 🚀 |
dhruvisompura
force-pushed
the
worktree-base-checkbox-themable-color
branch
from
e0f4da2 to
33a36e4
Compare
dhruvisompura
changed the title
dhruvisompura
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors Positron checkbox theming so a single set of tokens (
positronCheckbox.background,positronCheckbox.foreground,positronCheckbox.border) drive the base checkbox component insrc/vs/base/.../checkboxand the positron modal dialog checkboxes.The old
positronModalDialog.checkbox*tokens are removed in favor of these. Defaults preserve the prior visual appearance.Note: the current checkbox colors for the dark theme match other positron modal dialog input field colors. Once we create base theme colors for those, we could unify them to the default VS Code theme colors (so all checkboxes and inputs look the same).
Release Notes
New Features
Bug Fixes
Validation Steps
@:dialogs
Open any modal dialog with a checkbox (e.g., New Folder/Project flow) and verify the checkbox renders identically to a release build for the Default Positron Dark and Default Positron Light themes.