Skip to content

Add API for listening to file upload/download events#13809

Open
jmcphers wants to merge 3 commits into
mainfrom
feature/file-upload-download
Open

Add API for listening to file upload/download events#13809
jmcphers wants to merge 3 commits into
mainfrom
feature/file-upload-download

Conversation

@jmcphers
Copy link
Copy Markdown
Collaborator

This change adds a new API to Positron's positron.d.ts that makes it possible for extensions to be notified when files are uploaded or downloaded.

The implementation is pretty straightforward, and to make it easy to test and verify, the change also adds a tiny extension that uses this new API to display a notification when file uploads and downloads finish (an operation that is otherwise very quiet).

image

The notification can be disabled if desired.

Closes #13118.

Release Notes

This change is intended for use by Posit Workbench, so it doesn't get an entry in the release notes.

Validation Steps

  • Run Positron in web (browser) mode
  • Upload a file; check that notification appears
  • Download a file; check that notification appears

Test tags: @:web-only @:extensions

@github-actions
Copy link
Copy Markdown

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:web-only @:extensions

readme  valid tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add auditing for file uploads and downloads

1 participant