e2e: reload before R override test to fix flakiness#13799
Open
midleman wants to merge 3 commits into
Open
Conversation
The R override test was flaky on first attempt but consistently passed on retry. Adding an explicit window reload before the assertion gives the override setting a clean state to apply against. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
E2E Tests 🚀 |
The runtime discovery cache is stored at StorageScope.APPLICATION and survives window reloads, so R installs registered before the override setting was written stayed registered. A worker retry effectively wipes this cache via a fresh user-data-dir, which is why retry passed. Clearing the cache before the reload reproduces that state explicitly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
In web mode the Positron server process survives window reloads, so runtimes registered before the override setting was written remain in the runtime service registry. Only a Playwright worker restart wipes this state, which the test harness can't trigger between tests. Reverts the clear-cache + reload workaround in the R test (which didn't address the underlying server-side state) and drops the WEB tag from the entire Override describe. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit window reload at the start of the R override interpreter test. The test was flaky on first attempt but passed on retry, suggesting the override setting wasn't fully applied by the time the session start was attempted.
R - Can Override Interpreter Discovery; other 5 tests untouchedQA Notes
@:web @:interpreter