Fix cell editor context menu missing actions#13798
Open
seeM wants to merge 4 commits into
Open
Conversation
Replaces the useCellContextKeys hook with a CellContextKeyManager that is created when the cell container is attached. This moves context key lifecycle management out of the React layer and into the cell model, keeping the scoped context key service on the cell instance for consumers to access directly.
…scope The editor's scoped context key service was created as a sibling of the cell's scope (both children of the notebook scope). This meant cell-level context keys like positronNotebookCellIsFirst were invisible to menus evaluated inside the editor. Fix by creating the editor scope as a child of the cell's scope via useCellScopedContextKeyService().
seeM
changed the title
|
E2E Tests 🚀 |
nstrayer
approved these changes
May 27, 2026
Contributor
nstrayer
left a comment
nstrayer
left a comment
There was a problem hiding this comment.
🫡 Thank you for your bravery and dealing with scoped context keys.
seeM
force-pushed
the
refactor/cell-context-key-service
branch
2 times, most recently
from
523ba5e to
357e4f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10466
Cell-scoped context keys (e.g.
positronNotebookCellIsFirst) were not visible to cell editor menus because the editor's context key service was scoped to the notebook - not the cell.Release Notes
New Features
Bug Fixes
Validation Steps
@:notebooks @:positron-notebooks