Skip to content

fix: detect python version from project and use min Python version #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rich-iannone merged 2 commits into from
May 20, 2026
Merged

fix: detect python version from project and use min Python version #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cbc788
Require Python 3.11+ in CLI setup
rich-iannone May 20, 2026
f754778
Enforce min Python version from pyproject
rich-iannone May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions great_docs/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,11 +1269,21 @@ def setup_github_pages(
project_root = Path(project_path) if project_path else Path.cwd()

# Auto-detect Python version if not specified
# Great Docs requires Python 3.11+, so we enforce that as the floor
min_great_docs_version = (3, 11)
if python_version is None:
detected_version = _detect_python_version_from_pyproject(project_root)
if detected_version:
python_version = detected_version
click.echo(f"📦 Detected Python {python_version} from pyproject.toml")
detected_tuple = tuple(int(x) for x in detected_version.split("."))
if detected_tuple < min_great_docs_version:
python_version = f"{min_great_docs_version[0]}.{min_great_docs_version[1]}"
click.echo(
f"📦 Project requires Python {detected_version}, "
f"but Great Docs needs >={python_version}; using {python_version}"
)
else:
python_version = detected_version
click.echo(f"📦 Detected Python {python_version} from pyproject.toml")
else:
python_version = "3.12"
click.echo("📦 Using default Python 3.12 (no requires-python found)")
Expand Down
Loading