Polish area and ribbon layers#97
Merged
teunbrand merged 12 commits intoposit-dev:mainfrom Feb 5, 2026
Merged
Conversation
- Add render_ribbon tests for ymin/ymax to y/y2 translation - Add render_area tests for all stacking parameter values (on/off/fill/default) - Add render_area test for invalid stacking values - Fix render_ribbon bug: ymin should map to y2 not y - Update test_variant_aesthetics to use errorbar instead of ribbon
teunbrand
commented
Feb 3, 2026
teunbrand
commented
Feb 4, 2026
Comment on lines
+1175
to
+1176
| GeomType::Ribbon => render_ribbon(&mut encoding), | ||
| GeomType::Area => render_area(&mut encoding, layer)?, |
Collaborator
Author
There was a problem hiding this comment.
I'm slightly mad that I cannot seem to fit GeomType::Boxplot => render_boxplot(...) into the same match statement because it produces multiple layers.
thomasp85
approved these changes
Feb 4, 2026
Collaborator
thomasp85
left a comment
thomasp85
left a comment
There was a problem hiding this comment.
LGTM with some comments
Comment on lines
+34
to
+39
| fn default_params(&self) -> &'static [DefaultParam] { | ||
| &[DefaultParam { | ||
| name: "stacking", | ||
| default: DefaultParamValue::String("off"), | ||
| }] | ||
| } |
Collaborator
There was a problem hiding this comment.
We should find a unified position adjustment approach, but let's keep it for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linewidthaesthetic for both