Conversation
- Add cargo-packager configuration to src/Cargo.toml - Configured for Windows (NSIS, MSI), macOS (DMG), and Linux (Deb, RPM, AppImage) - Includes ggsql CLI and ggsql-rest binaries - Uses existing logo/icon assets - Add GitHub Actions workflow for automated releases - Builds installers for Windows, macOS, and Linux - Triggers on version tags (v*) - Uploads all installers to GitHub Releases - Add INSTALLERS.md documentation - Local build instructions for all platforms - Installation guides - CI/CD usage - Troubleshooting tips - Update .gitignore to exclude installer artifacts - *.msi, *.deb, *.rpm, *.dmg, *.AppImage - .cargo-packager/ directory Verified working: Windows NSIS and MSI installers tested successfully. Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
- Remove ggsql-rest from packaged binaries - Installers now only include the core CLI (ggsql) - Users can install ggsql-rest separately via cargo if needed - Reduces installer size: NSIS 22MB→12MB, MSI 31MB→15MB Updated documentation to reflect that ggsql-rest and ggsql-jupyter must be installed separately via cargo. Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
- Linux: Update libwebkit2gtk-4.0-dev to libwebkit2gtk-4.1-dev for Ubuntu 24.04 - macOS: Remove SVG icon (not supported), use PNG only - All platforms: Add explicit binary build steps before packaging Fixes GitHub Actions workflow failures: - Linux: Package not found error - macOS: SVG format not recognized - Windows: Binary path not found Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
cargo-packager does not support RPM format. Removed RPM build steps from the workflow and updated documentation accordingly. Supported Linux formats: - Debian (.deb) - for Debian/Ubuntu - AppImage - portable, distribution-agnostic Also updated Windows installer sizes in docs to reflect actual sizes after removing REST API (NSIS: 12MB, MSI: 15MB). Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
AppImage requires a square icon which we don't currently have. Simplified Linux builds to only produce Debian packages (.deb), which cover the majority of Linux users (Ubuntu, Debian, Mint, etc.). Removed formats: - AppImage (requires square icon) - RPM (not supported by cargo-packager) Remaining formats: - Windows: NSIS (.exe) and MSI - macOS: DMG (x86_64 and arm64) - Linux: Debian (.deb) Updated all documentation to reflect these changes. Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
Added comprehensive metadata to cargo-packager configuration: - Homepage: https://ggsql.org/ - Short description for package managers - Long description with feature overview - Copyright notice This metadata will appear in installer UI and package manager listings across all platforms (Windows, macOS, Linux). Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
Replaced Unicode curly quotes (" ") with plain ASCII double quotes (")
to fix character encoding issues in Windows installers.
The NSIS installer was displaying mojibake (“Softwareâ€) instead of
proper quotes. This fix ensures the license text displays correctly
across all installers and platforms.
Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
The correct field name is 'description', not 'short-description'. This was causing cargo-packager to fail with an unknown field error. Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
Add comprehensive release process documentation including: - Cross-platform installer overview - Step-by-step release checklist - Known limitations and workarounds - Current and future distribution channels Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
Collaborator
Author
|
The installers will probably be untrusted, because we're not signing code certificates or anything of the sort. |
cargo-packager builds binaries automatically when creating installers, so explicit cargo build steps are unnecessary. Removes 4 redundant steps: - Windows: 1 build step - macOS: 2 build steps (x86_64 and aarch64) - Linux: 1 build step Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
This reverts commit 0217fe3. The build steps are actually required because cargo-packager does not build binaries when run from a workspace subdirectory. It expects binaries to already exist in the target directory. The explicit build steps ensure binaries are placed in the correct location before cargo-packager attempts to package them. Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
Replace multi-line cd commands with cleaner working-directory directive for all cargo packager steps. Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
Replace build-from-source-only instructions with: - Native installer downloads (Windows/macOS/Linux) - Platform-specific installation steps - Security warning explanations - Component availability (CLI only in installers) - Build-from-source as alternative option Co-Authored-By: Claude (us.anthropic.claude-sonnet-4-5-20250929-v1:0) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #53.
Briefly, it adds installer generations using cargo packager. The builds are automated via a GHA workflow.
This is mostly Claude's work with me supervising.
A few notes:
I've so far tested:
I may need some help for testing the macOS/Linux installers. One should be able to download the installers from the GHA run, at the upload step there is a download URL, e.g. in https://github.com/teunbrand/ggsql/actions/runs/21516086643.