Skip to content

chore: upgrade to Vega-Lite v6 and Vega-Embed v7 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasp85 merged 1 commit into from
Jan 22, 2026
Merged

chore: upgrade to Vega-Lite v6 and Vega-Embed v7 #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ impl Writer for VegaLiteWriter {

// 2. Build Vega-Lite spec
let mut vl_spec = json!({
"$schema": "https://vega.github.io/schema/vega-lite/v5.json",
"$schema": "https://vega.github.io/schema/vega-lite/v6.json",
"data": {"values": data_values},
"width": 600,
"autosize": {"type": "fit", "contains": "padding"}
Expand Down Expand Up @@ -1256,7 +1256,7 @@ Plot {

```json
{
"$schema": "https://vega.github.io/schema/vega-lite/v5.json",
"$schema": "https://vega.github.io/schema/vega-lite/v6.json",
"data": {
"values": [
{"sale_date": "2024-01-01", "region": "North", "total": 150},
Expand Down
8 changes: 4 additions & 4 deletions ggsql-jupyter/src/display.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ fn format_vegalite(spec: String) -> Value {
paths: {{
'dom-ready': 'https://cdn.jsdelivr.net/npm/domready@1/ready.min',
'vega': 'https://cdn.jsdelivr.net/npm/vega@5/build/vega.min',
'vega-lite': 'https://cdn.jsdelivr.net/npm/vega-lite@5/build/vega-lite.min',
'vega-embed': 'https://cdn.jsdelivr.net/npm/vega-embed@6/build/vega-embed.min'
'vega-lite': 'https://cdn.jsdelivr.net/npm/vega-lite@6/build/vega-lite.min',
'vega-embed': 'https://cdn.jsdelivr.net/npm/vega-embed@7/build/vega-embed.min'
}}
}});

Expand Down Expand Up @@ -101,8 +101,8 @@ fn format_vegalite(spec: String) -> Value {

Promise.all([
loadScript('https://cdn.jsdelivr.net/npm/vega@5'),
loadScript('https://cdn.jsdelivr.net/npm/vega-lite@5'),
loadScript('https://cdn.jsdelivr.net/npm/vega-embed@6')
loadScript('https://cdn.jsdelivr.net/npm/vega-lite@6'),
loadScript('https://cdn.jsdelivr.net/npm/vega-embed@7')
])
.then(() => {{
vegaEmbed('#' + visId, spec, options)
Expand Down
4 changes: 2 additions & 2 deletions ggsql-jupyter/tests/test_compliance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ def test_execute_visualization(self):

# Check MIME types
data = execute_result["content"]["data"]
self.assertIn("application/vnd.vegalite.v5+json", data)
self.assertIn("application/vnd.vegalite.v6+json", data)

# Verify Vega-Lite spec structure
vega_spec = data["application/vnd.vegalite.v5+json"]
vega_spec = data["application/vnd.vegalite.v6+json"]
self.assertIn("$schema", vega_spec)
self.assertIn("data", vega_spec)

Expand Down
4 changes: 2 additions & 2 deletions ggsql-jupyter/tests/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,10 @@ def test_visualization_execution(self, client):

# Should have Vega-Lite MIME type
data = content["data"]
assert "application/vnd.vegalite.v5+json" in data
assert "application/vnd.vegalite.v6+json" in data

# Check Vega-Lite spec structure
vega_spec = data["application/vnd.vegalite.v5+json"]
vega_spec = data["application/vnd.vegalite.v6+json"]
assert "$schema" in vega_spec
assert "data" in vega_spec
assert "mark" in vega_spec or "layer" in vega_spec
Expand Down
4 changes: 2 additions & 2 deletions src/writer/vegalite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ use std::collections::HashMap;

/// Vega-Lite JSON writer
///
/// Generates Vega-Lite v5 specifications from ggsql specs and data.
/// Generates Vega-Lite v6 specifications from ggsql specs and data.
pub struct VegaLiteWriter {
/// Vega-Lite schema version
schema: String,
Expand All @@ -41,7 +41,7 @@ impl VegaLiteWriter {
/// Create a new Vega-Lite writer with default settings
pub fn new() -> Self {
Self {
schema: "https://vega.github.io/schema/vega-lite/v5.json".to_string(),
schema: "https://vega.github.io/schema/vega-lite/v6.json".to_string(),
}
}

Expand Down