Open
Conversation
554d612 to
9579236
Compare
ef3826e to
d79753d
Compare
Collaborator
|
Looks like we need air/editors/code/src/process.ts Lines 15 to 25 in 1502872 Can you please make that change too? Trying to get the Code extension test workflow passing |
DavisVaughan
reviewed
Dec 2, 2025
9e587fb to
7622118
Compare
Collaborator
Author
|
To fix: Caused by vs-code depending on a version of glob that is incompatible with the latest safe version: istanbuljs/test-exclude#67 I've downgraded glob to 9.x.x, which is safe: isaacs/node-glob#639 (comment) There was also a dep cycle issue with brace-expansion: I downgraded to Node 22 to fix it. It seems generally better to lag a few versions of Node in vscode extensions. This all seemed a bit unnecessary for a dev dependency but this got my feet wet with web dev dependency hell... |
7622118 to
4b2f586
Compare
To avoid a dependency cycle issue due to our pinning of glob 9.x.x
4b2f586 to
8681737
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.