Skip to content

Allow Symfony 7.#12

Open
slashrsm wants to merge 7 commits intoportphp:masterfrom
slashrsm:symfony_7
Open

Allow Symfony 7.#12
slashrsm wants to merge 7 commits intoportphp:masterfrom
slashrsm:symfony_7

Conversation

@slashrsm
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR broadens this package’s Composer dependency constraints to allow installing Symfony Console v7 alongside the already-supported Symfony Console major versions.

Changes:

  • Extend symfony/console version constraint to include ^7.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

.github/workflows/checks.yml:39

  • matrix.composer-prefer is used in the cache key and composer update command, but it is not defined in the matrix anymore. This makes the cache key less effective and can make the command harder to reason about; consider defining a composer-prefer axis (e.g. default vs --prefer-lowest) or remove it from the key/command entirely.
        uses: actions/cache@v4
        with:
          path: vendor
          key: ${{ runner.os }}-composer-${{ matrix.composer-prefer }}$-${{ hashFiles('**/composer.lock') }}
          restore-keys: |
            ${{ runner.os }}-composer-${{ matrix.composer-prefer }}-

      - name: Install dependencies
        run: composer update --prefer-dist --no-progress --ignore-platform-req="ext-*" ${{ matrix.composer-prefer }}

.github/workflows/checks.yml:24

  • The matrix defines only php-versions, but later steps reference matrix.coverage and matrix.composer-prefer. Please either add these keys back into the matrix (with defaults) or remove the references so the workflow inputs/cache keys are not empty/invalid.
      - uses: actions/checkout@v4

      - name: Set up PHP
        uses: shivammathur/setup-php@v2
        with:
          php-version: ${{ matrix.php-versions }}
          coverage: ${{ matrix.coverage }}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coverage: pcov
composer-prefer: '--prefer-lowest --prefer-stable'
phpunit-flags: '--coverage-clover coverage.xml'
php-versions: [ '8.2', '8.3', '8.4', '8.5' ]
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

composer.json declares support for PHP ^5.6 || ^7.0 || ^8.0, but CI now only runs on PHP 8.2+. If older PHP versions are still supported, consider keeping at least one job for the lowest supported PHP to catch compatibility issues; otherwise update the php constraint to match the supported/tested range.

Suggested change
php-versions: [ '8.2', '8.3', '8.4', '8.5' ]
php-versions: [ '5.6', '8.2', '8.3', '8.4', '8.5' ]

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants