Conversation
There was a problem hiding this comment.
Pull request overview
This PR broadens this package’s Composer dependency constraints to allow installing Symfony Console v7 alongside the already-supported Symfony Console major versions.
Changes:
- Extend
symfony/consoleversion constraint to include^7.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
.github/workflows/checks.yml:39
matrix.composer-preferis used in the cache key andcomposer updatecommand, but it is not defined in the matrix anymore. This makes the cache key less effective and can make the command harder to reason about; consider defining acomposer-preferaxis (e.g. default vs--prefer-lowest) or remove it from the key/command entirely.
uses: actions/cache@v4
with:
path: vendor
key: ${{ runner.os }}-composer-${{ matrix.composer-prefer }}$-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-${{ matrix.composer-prefer }}-
- name: Install dependencies
run: composer update --prefer-dist --no-progress --ignore-platform-req="ext-*" ${{ matrix.composer-prefer }}
.github/workflows/checks.yml:24
- The matrix defines only
php-versions, but later steps referencematrix.coverageandmatrix.composer-prefer. Please either add these keys back into the matrix (with defaults) or remove the references so the workflow inputs/cache keys are not empty/invalid.
- uses: actions/checkout@v4
- name: Set up PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
coverage: ${{ matrix.coverage }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| coverage: pcov | ||
| composer-prefer: '--prefer-lowest --prefer-stable' | ||
| phpunit-flags: '--coverage-clover coverage.xml' | ||
| php-versions: [ '8.2', '8.3', '8.4', '8.5' ] |
There was a problem hiding this comment.
composer.json declares support for PHP ^5.6 || ^7.0 || ^8.0, but CI now only runs on PHP 8.2+. If older PHP versions are still supported, consider keeping at least one job for the lowest supported PHP to catch compatibility issues; otherwise update the php constraint to match the supported/tested range.
| php-versions: [ '8.2', '8.3', '8.4', '8.5' ] | |
| php-versions: [ '5.6', '8.2', '8.3', '8.4', '8.5' ] |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.