feat: add optional at prop to insert.text event#2230
Draft
christianhg wants to merge 1 commit intomainfrom
Draft
feat: add optional at prop to insert.text event#2230christianhg wants to merge 1 commit intomainfrom
at prop to insert.text event#2230christianhg wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 3c880bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
christianhg
force-pushed
the
feat/insert-text-at
branch
from
ed1994c to
3c880bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
atprop to theinsert.textevent for programmatic text insertion at a specific location. This lets callers insert text without moving the current selection.Changes
behavior.types.event.ts: Addedat?: NonNullable<EditorSelection>toinsert.text, matchinginsert.block,delete,annotation.add, etc.operation.insert.text.ts: Convertsatto a Slate range and passes it toTransforms.insertText. Falls back to current selection when omitted.behavior.abstract.insert.ts: Expanded selection and no-selection behaviors useevent.at ?? snapshot.context.selectionas their operating location (same pattern asinsert.blocks).behavior.core.insert.ts: Pending marks behavior skips whenatis provided, since pending marks are selection-relative state. Inserted text inherits marks from the surrounding context at the target location instead.