omit Sql properties absent from TransactionSql in type definition

[maxcbc]

TransactionSql is missing properties from Sql added in

postgres/src/index.js

Lines 69 to 82 in 32feb25

	Object.assign(sql, {
	get parameters() { return options.parameters },
	largeObject: largeObject.bind(null, sql),
	subscribe,
	CLOSE,
	END: CLOSE,
	PostgresError,
	options,
	reserve,
	listen,
	begin,
	close,
	end
	})

.

This PR updates the type definition of TransactionSql to reflect this.

This means typescript will now raise an error if consuming code tries the following:

sql.begin((trx) => {
   trx.begin((trx2) => {
       ...
   })
})

[porsager]

Thx :) Not into typescript, but looks about right 😅

[stephenh]

@porsager / @maxcbc this caused a pretty serious regression, i.e. all sql calls within sql.begins are now broken:

sql.begin(async (sql) => {
  await sql`my query`; // <== error here:
  // TS2349: This expression is not callable.
  // Type TransactionSql<{}> has no call signatures.
});

See Dimous's comment here:

36a53f6#commitcomment-170665877

@maxcbc do you mind either preparing a revert, or fixing forward?

...also I'm kinda curious, @maxcbc how did this regression not show up in your codebase? Afaict like every sql`` within a sql.begin is broken for me.

@porsager I get you personally do not like TypeScript, but some amount of type checking-as-unit-tests in the postgres.js build/release process would likely be a good idea, otherwise folks maintaining these types are just guessing about what will/will not fix/improve/regress the types.

[AntonOfTheWoods]

So @porsager even though this probably broke the code of every typescript user of this library and the issue was raised well before releasing the new version - "I don't like typescript"?

[porsager]

Tell me if there's a PR or make one, and I'll merge and make a release.

[sep2]

@porsager PR #1144
tested locally did not break anything.