Skip to content

Conversation

@alphak3y
Copy link
Contributor

No description provided.

alphak3y and others added 24 commits December 8, 2023 13:15
* switch to solidity 0.8.18

* dynamic fee config on manager
* switch to solidity 0.8.18

* dynamic fee config on manager

* deploy single pool; use correct start price
* safe transfers balance check removed

* test transferInto address(0)

* remove it only

* get correct expected position id

* add burn for testing
* return amount deltas

* range amount deltas
* router msg value check

* return if eth amount 0; block receives from non-weth address
* cleanup before prettier

* format all contracts

* document interfaces

* add comments to major contracts; protocol fee testing

* prettier contracts

* exclude coverage
@codecov
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 55 lines in your changes are missing coverage. Please review.

Comparison is base (5e789ee) 94.63% compared to head (817c3dc) 93.82%.

❗ Current head 817c3dc differs from pull request most recent head e37a40b. Consider uploading reports for the commit e37a40b to get more accurate results

Files Patch % Lines
contracts/libraries/Samples.sol 78.94% 8 Missing ⚠️
contracts/libraries/limit/Claims.sol 84.31% 8 Missing ⚠️
contracts/libraries/limit/LimitTicks.sol 86.53% 7 Missing ⚠️
contracts/libraries/math/ConstantProduct.sol 91.66% 7 Missing ⚠️
contracts/libraries/Ticks.sol 95.45% 4 Missing ⚠️
contracts/libraries/range/RangeTicks.sol 71.42% 4 Missing ⚠️
contracts/LimitPool.sol 90.00% 3 Missing ⚠️
contracts/libraries/limit/EpochMap.sol 81.25% 3 Missing ⚠️
contracts/libraries/range/RangePositions.sol 94.44% 2 Missing ⚠️
contracts/libraries/range/pool/MintRangeCall.sol 88.88% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   94.63%   93.82%   -0.82%     
==========================================
  Files          31       26       -5     
  Lines        1697     1683      -14     
  Branches      444      450       +6     
==========================================
- Hits         1606     1579      -27     
- Misses         91      104      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants