-
Notifications
You must be signed in to change notification settings - Fork 3
Arbitrum Mainnet Release #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alphak3y
wants to merge
39
commits into
master
Choose a base branch
from
arb-mainnet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to solidity 0.8.18 * dynamic fee config on manager
* switch to solidity 0.8.18 * dynamic fee config on manager * deploy single pool; use correct start price
* safe transfers balance check removed * test transferInto address(0) * remove it only * get correct expected position id * add burn for testing
* return amount deltas * range amount deltas
* router msg value check * return if eth amount 0; block receives from non-weth address
* cleanup before prettier * format all contracts * document interfaces * add comments to major contracts; protocol fee testing * prettier contracts * exclude coverage
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 94.63% 93.82% -0.82%
==========================================
Files 31 26 -5
Lines 1697 1683 -14
Branches 444 450 +6
==========================================
- Hits 1606 1579 -27
- Misses 91 104 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.