Dev

[hyuuuun]

개요

관련 BackLog

Resolves: (Backlog Number, ...)

PR 유형

• 새로운 기능 추가
• 버그 수정
• CSS 등 사용자 UI 디자인 변경
• 코드에 영향을 주지 않는 변경사항(오타 수정, 탭 사이즈 변경, 변수명 변경)
• 코드 리팩토링
• 주석 추가 및 수정
• 문서 수정
• 테스트 추가, 테스트 리팩토링
• 빌드 부분 혹은 패키지 매니저 수정
• 파일 혹은 폴더명 수정
• 파일 혹은 폴더 삭제

PR Checklist

• 커밋 메시지 컨벤션에 맞게 작성했습니다.
• 변경 사항에 대한 테스트를 했습니다.(버그 수정/기능에 대한 테스트).

Summary by CodeRabbit

• Bug Fixes
  • Updated the data visibility logic for app data usage. The system now correctly determines public/private status based on permission settings and family line configuration, improving accuracy in how data visibility is handled across shared accounts.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1a68c87a-03f7-4d8a-873d-69a014076293

📥 Commits

Reviewing files that changed from the base of the PR and between 8207e87 and 07be786.

📒 Files selected for processing (2)

• src/main/java/com/pooli/data/service/impl/DataServiceImpl.java
• src/test/java/com/pooli/data/service/impl/DataServiceImplTest.java

---

📝 Walkthrough

Walkthrough

The PR modifies the privacy/public visibility logic in getAppDataUsage(...) method. The isPublic computation now derives solely from permissionEnabled instead of requiring both permissionEnabled and familyLine.getIsPublic() to be true. Test cases are updated to reflect the new behavior with adjusted assertions and mocking.

Changes

Cohort / File(s)	Summary
Privacy Logic Update src/main/java/com/pooli/data/service/impl/DataServiceImpl.java	Modified isPublic computation to use !canUsePrivacy || familyLine.getIsPublic() instead of requiring both conditions to be true, changing how privacy state is propagated in responses.
Test Suite Updates src/test/java/com/pooli/data/service/impl/DataServiceImplTest.java	Updated multiple test cases including: renamed getAppDataUsage_permissionDisabled_returnsPrivate to reflect new behavior; adjusted data usage assertions for personalUsedAmount, personalTotalAmount, and sharedPoolRemainingAmount; added new test getAppDataUsage_permissionDisabled_returnsUsage with corrected expectations; added test for unlimited shared pool scenario; updated mock stubs for consistency with new logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• Dev #313: Directly modifies the same getAppDataUsage public/privacy visibility logic and related test coverage.

Suggested labels

bug

Suggested reviewers

• hyeonRS
• pjh813
• Misu0616

Poem

🐰 Privacy logic took a twist so fine,
No more AND gates in the design,
Now OR lets the public shine,
When permissions align with the line,
Tests bloom fresh with assertions refined! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Misu0616]

마지막 수정이길,,,