Skip to content

Fix hanging pipe #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeviousStoat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix hanging pipe #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions pyvirtualdisplay/abstractdisplay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,15 @@ def _popen(self, use_pass_fds):
self._subproc = subprocess.Popen(
self._command,
pass_fds=[self._pipe_wfd],
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
shell=False,
)
else:
self._subproc = subprocess.Popen(
self._command,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
shell=False,
)

Expand Down Expand Up @@ -340,7 +340,6 @@ def _kill_subproc(self):
log.debug("exception in kill:%s", oserror)

self._subproc.wait()
self._read_stdout_stderr()

def stop(self):
"""
Expand All @@ -365,13 +364,6 @@ def stop(self):
self._display_to_rm = None
return self

def _read_stdout_stderr(self):
if self.stdout is None:
(self.stdout, self.stderr) = self._subproc.communicate()

log.debug("stdout=%s", self.stdout)
log.debug("stderr=%s", self.stderr)

def _setup_xauth(self):
"""
Set up the Xauthority file and the XAUTHORITY environment variable.
Expand Down Expand Up @@ -416,9 +408,6 @@ def is_alive(self):
return False
# return self.return_code is None
rc = self._subproc.poll()
if rc is not None:
# proc exited
self._read_stdout_stderr()
return rc is None

# @property
Expand Down