Skip to content

Small improvements #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vogti merged 3 commits into from
Feb 24, 2025
Merged

Small improvements #22

vogti merged 3 commits into from
Feb 24, 2025

Conversation

@gartens
Copy link
Contributor

@gartens gartens commented Feb 18, 2025

  • Prevent a NullPointerException if queryMode is missing
  • Round doubles directly without formatting and then parsing a string
  • Use a Queue instead of a List to share queries between threads

@gartens
Improve rounding of doubles
9d185a5
@gartens
Check if key exists to prevent NullPointerException
31c7c73 
The switch statement calls hashCode on the value.  When the key is not present,
this leads to hashCode being called on a null value.
@gartens
Use Queue instead of List for queries
7425d70
vogti
vogti approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@vogti vogti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @gartens, for this PR!

@vogti vogti merged commit d468561 into master Feb 24, 2025
6 checks passed
@vogti vogti deleted the small-improvements branch February 24, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vogti vogti vogti approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gartens @vogti